rbatten / gnome-mplayer

Automatically exported from code.google.com/p/gnome-mplayer
GNU General Public License v2.0
0 stars 0 forks source link

Playlist: item names in "Items to Play" replaced with cpuid string #682

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. start gnome-mplayer with a bunch of files
2. start playing them all
3. as each movie is started, its title (first field in row) is replaced with a 
cpuid string. In my case this is "GenuineIntel max cpuid level: 13"

What is the expected output? What do you see instead?

The title should stay

I'm happy to work some on tracking this down, could you give me a hint where to 
start?

Original issue reported on code.google.com by hanse...@gmail.com on 22 May 2013 at 4:26

GoogleCodeExporter commented 8 years ago
Which version of gnome-mplayer and gmtk are you using? gmtk does the parsing of 
the output from mplayer. So you might want to look at the thread_reader 
function in gmtk_media_player.c

Original comment by kdeko...@gmail.com on 23 May 2013 at 3:44

GoogleCodeExporter commented 8 years ago
I'm using SVN. I've been playing around with config options a bit, they 
currently are:

gmtk: --enable-gtk3 --disable-gconf
gnome-mplayer: --disable-nautilus --enable-gtk3 --without-libgda

I'll look at the function and do some investigating.

Original comment by hanse...@gmail.com on 23 May 2013 at 4:22

GoogleCodeExporter commented 8 years ago
Okay, this was fairly easy:

name_regex also triggers for the string "CPU vendor name:". Adding an extra 
check:

@@ -3689,7 +3693,8 @@
             gtk_widget_destroy(dialog);
         }

-        if (g_regex_match(player->name_regex, mplayer_output->str, 0, NULL)) {
+        if (g_regex_match(player->name_regex, mplayer_output->str, 0, NULL) && 
(g_strrstr(mplayer_output->str, "CPU vendor name:") == NULL)) {

I'll make a clean patch and apply

Original comment by hanse...@gmail.com on 4 Jun 2013 at 9:09

GoogleCodeExporter commented 8 years ago
Committed in SVN revision #220.

If anybody feels like verifying etc...

Original comment by hanse...@gmail.com on 4 Jun 2013 at 9:13