search

rbb-data / starter

https://main-rbb-data.errnesto.vercel.app/
MIT License
4 stars 1 forks source link

Problems with Search / SearchInput stories #5

Closed rrrnld closed 4 years ago

rrrnld commented 4 years ago

Looking at the sotrybook I noticed some problems with the components mentioned above:

  1. It is not really clear to me why there is a Search and a SearchInput component or what the difference is
  2. The LocationSearch example only lists opencage options. This should be deprecated if I'm correct? At least for rbb|24 it is.

Forget about 2.) please, I just can't read properly…

errnesto commented 4 years ago

For some reason storybook does not display the comment sting for SearchInput :-( I also tried to make it more clear:

SearchInput that can show a list of suggestions This component provides no logic it just renders the search string and the provided result list and provides event handlers for user actions

The Search story is a collection of hooks and examples how to use the search input the docstring says:

This is a basic example of how to use the search SearchInput component component with Openrouteservice you can use this as is – or as an example for creating your own search

errnesto commented 4 years ago

@heyarne would you say this is resolved by ebd1b53 and the text above?