Define STRICT_R_HEADERS and fix resulting problems

rbchan / unmarked

R package for hierarchical models in ecological research

https://rbchan.github.io/unmarked/

37 stars 25 forks source link

Define STRICT_R_HEADERS and fix resulting problems #202

Closed kenkellner closed 3 years ago

kenkellner commented 3 years ago

This PR addresses the issues raised in https://github.com/RcppCore/Rcpp/issues/1158. Rather than define STRICT_R_HEADERS in many files I instead added PKG_CPPFLAGS=-DSTRICT_R_HEADERS to the Makevars. As expected this resulted in immediate failure to compile.

All that was required was to include float.h and change instances of DOUBLE_XMIN to DBL_MIN in a few files. The package checks clean for me now and the tests pass.

Fixes #201

eddelbuettel commented 3 years ago

Thank you for the swift action!