search

rbdannenberg / soundcool

Port of Soundcool to Web Audio
9 stars 7 forks source link

soundcool project editor layout #47

Open masaeal opened 4 years ago

masaeal commented 4 years ago

(I think there are too many problems to make an issue for each. All of these are Priority Critical.)

NOT DONE:

  1. Floating view has:
    • fixed width, doesn't scale with window size
    • large margins around an inner window depending on window size
    • no horizontal scroll bar so modules can be lost off to the right when window is resized
    • cannot expand vertically by much -- really unusable if you want a larger window
    • why do we have any panel at all instead of just using the main window where the icons are? -- why can't this window be the entire browser window (except for the menu bar?) Can we make the window resize when you drag a module beyond the border? If not, let's just have a fixed sized window for Alpha, or one step better would be put a drag-able handle on the bottom of the window that you could use to make the edit area taller.
  2. Column view has similar problems with large margins
  3. Column view: columns disappear if you make the window narrower.
  4. Column view has nice drag interaction. Floating view has only a tiny drag icon you have to use. (And now the drag behavior is different in the two views.)
  5. Big margins around modules in Column mode.

DONE:

  1. Column labels ("Column 1", "Column 2", ...) should be removed.

  2. Remove Create button from lower right corner of edit window.

  3. Icons at the top left (currently not at the top).

  4. Tooltips float off screen -- especially bad for icons on the left edge of screen.

  5. Many icons are for modules that are not implemented. Need to remove non-functional icons. See Alpha Release Modules for list of modules: https://github.com/rbdannenberg/soundcool/wiki/Modules-Status-Table

  6. "About Us" needs work. Every name has "description" below it. Not sure what our roles should be, but let's fix it.

  7. SignalGen tooltip is "Signalgen" instead of "SignalGen"

  8. Granular Synthesis tooltip instead of "GranSynth" -- I'm not opposed to writing out descriptions instead of names, but I don't like having a mix.

  9. Direct Input instead of "DirectInput"

  10. GranSynth module minimize, close and out buttons are in the wrong places.

  11. SignalGen module minimize, close and out buttons are in the wrong places.

  12. Project Menu: Change "Floating view: On" to "Column View"; change "Floating View: Off" to "Floating View" (OK, thanks for implementing what I asked for, but it still seems wrong. I think we need something like "[ ] Column View" with a clear checkbox that is checked when in column view. If checkbox is hard to implement, just replace "Floating View" with "□Column View" and replace "Column View" with "✔Column View" (Maybe you can find better characters -- I was looking for just an empty box and a matching box with an X or check.)

  13. If checkbox is hard to implement, just replace "Floating View" with "□Column View" and replace "Column View" with "✔Column View" (Maybe you can find better characters -- I was looking for just an empty box and a matching box with an X or check.) [consider X and ✔ to be equivalent -- right now you can switch from X to ✔ but that's very confusing and non-standard]

  14. Why is Soundcool icon not on the far left?

  15. When I put speaker at the top of column, gransynth below it, and connect gransynth to speaker, they swapped places(!)

  16. I got two tooltips for the same icon to appear at the same time in different font sizes. Might be related to changing from column mode to floating view and back.

anusfoil commented 4 years ago
screenshot

Hi I tried it and the icons seems to be a little bit small. Is this screenshot what you intended for? If yes then I will push the changes to the repository. @masaeal Also I think a few of the module icons are missing like Signal generator?

rbdannenberg commented 4 years ago

I think the icons look good at that size, but there's only one column of buttons, which is going to be too tall when the floating view button is moved there. (Also the granular synthesis button and SignalGen button.) Do we need a "Create" button? The AddColumn and RemoveColumn buttons and the column headers should eventually go away.

-Roger

On 4/28/20 5:22 PM, Huan Zhang wrote:

Hi I tried it and the icons seems to be a little bit small. Is this screenshot what you intended for? If yes then I will push the changes to the repository. Also I think a few of the module icons are missing like Signal generator?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rbdannenberg/soundcool/issues/47#issuecomment-620862555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALLUHHRWIQLKEBJSAGMSJ3RO5CK7ANCNFSM4MS45GYQ.

masaeal commented 4 years ago

Hi @rbdannenberg , i think that I have fixed up the problem with the float view margins. On the other hand, i have extended the float view in the layout.

I send you an image when you can see the changes made.

Also, I send you the scripts so that it can be added to the new soundcool_setup.exe

floatView

projectEditor.zip