rbdl / rbdl-toolkit

Application for visualizing and working with rbdl models
European Union Public License 1.2
19 stars 11 forks source link

Update to use Qt6 #25

Closed idlebear closed 3 years ago

idlebear commented 3 years ago

Updates required to build with Qt6. Some cleanup to use the appropriate Qt CMake variables.

Just a heads up that there is a warning that QVariant::Type has been deprecated but I haven't tackled that one as it looks like it will require replacing the QVariantDelegate class with a QMeta. Not a short fix.

Also updated the submodule QVideoWriter and will submit a pull request there as well

ju6ge commented 3 years ago

Thank you very much for your effort! Before merging I will have to try and build the appimage with this and also look into the QMeta thing. Sadly I don't have as much time as I would like at the moment. But as soon as my other deadlines are done, I'll come back to this.

idlebear commented 3 years ago

No worries at all -- I'm also loaded this week with a couple projects due. If I get a moment, I'll take another look.


From: Felix Richter notifications@github.com Sent: Monday, February 15, 2021 5:04 PM To: ORB-HD/rbdl-toolkit rbdl-toolkit@noreply.github.com Cc: Barry Gilhuly barry.gilhuly@uwaterloo.ca; Author author@noreply.github.com Subject: Re: [ORB-HD/rbdl-toolkit] Update to use Qt6 (#25)

Thank you very much for your effort! Before merging I will have to try and build the appimage with this and also look into the QMeta thing. Sadly I don't have as much time as I would like at the moment. But as soon as my other deadlines are done, I'll come back to this.

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ORB-HD/rbdl-toolkit/pull/25#issuecomment-779467716, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACY5FME42JCKR4L2QFFW3WTS7GK5JANCNFSM4XVJTJ3A.