search

rbeauchamp / Swashbuckle.OData

Extends Swashbuckle with OData v4 support!
Other
128 stars 96 forks source link

Add support for xmlComments and for using swaggerResponseAttributes a… #132

Closed cibergarri closed 7 years ago

cibergarri commented 7 years ago

…nd OdataResponse and its subclasses on nested resources. Allow ODataResponse metadata property to be overrided. Creaete ODataListResponse for Ienumerable Responses with Odata properties

rbeauchamp commented 7 years ago

hey @cibergarri, thank you for these updates. Looks like 2 of the test are failing.

cibergarri commented 7 years ago

Oops, some last minute changes, sorry. Fixed.

cibergarri commented 7 years ago

Hi Richard!! First of all, thanks for accepting my PR!

Since I have contributed to this project, shouldn't I appear in the contributors list? It's the very first time I colaborate in an open source project and I don't know exactly how it works ... But it would make me happy :)

rbeauchamp commented 7 years ago

Hi @cibergarri, thank you for the PRs! I've made a point of changing the author and the copyright to include 'and the Swashbuckle.OData contributors'. I don't currently have a contributors list but would be happy to include one: can you point me to an open-source project that does a good job including or displaying and contributors list?

On Wed, Mar 15, 2017, 3:25 AM cibergarri notifications@github.com wrote:

Hi Richard!! First of all, thanks for accepting my PR!

Since I have contributed to this project, shouldn't I appear in the contributors list? It's the very first time I colaborate in an open source project and I don't know exactly how it works ... But it would make me happy :)

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/rbeauchamp/Swashbuckle.OData/pull/132#issuecomment-286701053, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcwbRAit2Kluttzh5SyVQ-MclZah5gKks5rl7yugaJpZM4MaZw0 .

cibergarri commented 7 years ago

Oh! I was just referring to the github contributors list! But don't worry, it is not importante at all.

Obtener Outlook para Androidhttps://aka.ms/ghei36

From: Richard Beauchamp notifications@github.com Sent: Wednesday, March 15, 2017 2:09:09 PM To: rbeauchamp/Swashbuckle.OData Cc: cibergarri; Mention Subject: Re: [rbeauchamp/Swashbuckle.OData] Add support for xmlComments and for using swaggerResponseAttributes a… (#132)

Hi @cibergarri, thank you for the PRs! I've made a point of changing the author and the copyright to include 'and the Swashbuckle.OData contributors'. I don't currently have a contributors list but would be happy to include one: can you point me to an open-source project that does a good job including or displaying and contributors list?

On Wed, Mar 15, 2017, 3:25 AM cibergarri notifications@github.com wrote:

Hi Richard!! First of all, thanks for accepting my PR!

Since I have contributed to this project, shouldn't I appear in the contributors list? It's the very first time I colaborate in an open source project and I don't know exactly how it works ... But it would make me happy :)

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/rbeauchamp/Swashbuckle.OData/pull/132#issuecomment-286701053, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcwbRAit2Kluttzh5SyVQ-MclZah5gKks5rl7yugaJpZM4MaZw0 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/rbeauchamp/Swashbuckle.OData/pull/132#issuecomment-286735936, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATOMrONN0v74g52rSvxagV9Ix28vwuW6ks5rl-L1gaJpZM4MaZw0.

rbeauchamp commented 7 years ago

@cibergarri It is strange that you are not showing up on the contributors list. This is something automatically handled by github. When you look here: https://github.com/rbeauchamp/Swashbuckle.OData/commits/master I see your commits but don't see your picture and there is no link on your username as there is with other contributors. ????

cibergarri commented 7 years ago

I think it's because of someone of the reasons mentioned here: https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile/

Thanks anyway!

From: Richard Beauchamp notifications@github.com Sent: Wednesday, March 15, 2017 7:20:44 PM To: rbeauchamp/Swashbuckle.OData Cc: Javier Garrido; Mention Subject: Re: [rbeauchamp/Swashbuckle.OData] Add support for xmlComments and for using swaggerResponseAttributes a… (#132)

@cibergarrihttps://github.com/cibergarri It is strange that you are not showing up on the contributors list. This is something automatically handled by github. When you look here: https://github.com/rbeauchamp/Swashbuckle.OData/commits/master I see your commits but don't see your picture and there is no link on your username as there is with other contributors. ????

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/rbeauchamp/Swashbuckle.OData/pull/132#issuecomment-286834302, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATOMrOdHyHh1e1P3f55uX_7Fs9UPKVT8ks5rmCv8gaJpZM4MaZw0.