search

rbeckman-nextgen / test-mc

test-migration
1 stars 0 forks source link

TCP Remote Address field does accept <4 character hostname #3677

Open rbeckman-nextgen opened 4 years ago

rbeckman-nextgen commented 4 years ago

Mirth Connect version: 3.2.2.7694

The TCP Remote Address field does not accept a hostname that is less than 4 characters long. The connection can test successfully, but it will not let you save and deploy the channel.

Imported Issue. Original Details: Reporter: brianb Created: 2015-07-27T12:31:27.000-0700

rbeckman-nextgen commented 4 years ago

It looks to be "intentional"; that change was made way back in [r2278|http://www.mirthcorp.com/community/fisheye/changelog/Mirth?cs=2278]. I doubt [~jacobb] remembers why that change was made though.

The lexical grammar in [RFC 952|https://tools.ietf.org/html/rfc952] appears to define a hostname having a minimum of 1 character, but then it also indicates that "Single character names or nicknames are not allowed." RFCs 1034/1035 also indicate a minimum of 1 character. Technically if you're talking about domain names, 2 characters would be the minimum if you just use the root-level country code in a [ccTLD|https://en.wikipedia.org/wiki/Country_code_top-level_domain]. But in general it sounds like we should just be doing an isBlank check instead.

I'm sure it varies depending on the OS or DNS resolver implementation. But assuming that the user is on an environment that supports it, we shouldn't disallow that in the TCP Sender validation.

Imported Comment. Original Details: Author: narupley Created: 2015-07-27T13:01:14.000-0700