search

rbeckman-nextgen / test-mc3

0 stars 0 forks source link

Importing a channel as a part of a server config does not preserve the revision number #2666

Open rbeckman-nextgen opened 4 years ago

rbeckman-nextgen commented 4 years ago

If you're importing a channel that doesn't exist, the revision is set to 1 no matter what.

If you're importing a channel that already exists, the revision is set to one plus the current revision in the database, ignoring what revision was passed in.

Both of those actions are intentional, and make sense for most cases. The problem comes when you import a server configuration. If the server config is meant to restore the state of the server to exactly what it was at a previous time, it's currently not doing that for channels that it overwrites. This can cause issues when the deployed channel cache still contains old revisions of channels after the restore (MIRTH-2756). However the bigger issue is perhaps that importing a server config does not have the "exact state of the server's persisted data (excluding messages)" property that we want it to have.

Imported Issue. Original Details: Jira Issue Key: MIRTH-2757 Reporter: narupley Created: 2013-07-13T20:23:35.000-0700

rbeckman-nextgen commented 4 years ago

It may make sense to change this behavior when we do MIRTH-1866. Once MIRTH-1866 is complete, it will make it easier to separate "import" logic from "save" logic.

Imported Comment. Original Details: Author: jacobb Created: 2013-07-13T21:14:54.000-0700