search

rbeer / nodebb-plugin-smoothshorts

Seamless short URLs for topic and post links in NodeBB.
MIT License
5 stars 2 forks source link

Things to test in 0.3.0-pre? #9

Closed GitPuffy closed 8 years ago

GitPuffy commented 8 years ago

Aside from the ability to change around the shortlink URL (which is ahhmazing, btw) is there anything else significant that I should see in 0.3.0-pre? I am using the Lavender theme, if that matters.

Thank you.

rbeer commented 8 years ago

Not yet, no. I am in the midst of figuring out the best way to implement #3.

GitPuffy commented 8 years ago

Btw, I had to manually install xxhash to get 0.3.0-pre working. npm install xxhash

I do not know if that is something your package should know about or not.

rbeer commented 8 years ago

It should and actually does: package.json#L9-L11 npm install should have been enough.

The thing is that NPM installs the dependencies implicitly, when you install a package (e.g. npm install nodebb-plugins-smoothshorts). NodeBB issues basically the same command when you install plugins from the ACP. If you, however, clone a repo, you'll have to take that step yourself and do the npm install. NPM looks for package.json in the current directory and installs that, if you don't give install a package name. :)

rbeer commented 8 years ago

@GitPuffy New toy arrived in master. :wink:

merged/published in 0.3.0 / 1386a2a