rbelow / blueprintcss

Automatically exported from code.google.com/p/blueprintcss
1 stars 0 forks source link

v0.5 - container class does not clear:after #24

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
1. create a page using the examples
2. set borders on the container div
3. notice the borders do not frame the page but indicate that the container div 
has collapsed due to 
the inside columns floating left.

This is particularly obvious when using different background colours for the 
body and the container 
div as the entire page will end up having the bgcolor of the body.

A little digging reveals that the .container:after css declaration has been 
dropped in version 0.5. 
Adding that back in from the old version fixes the issue.

I have tested in Safari 3.0.3 and Firefox 2.0 on MacOS X with consistent 
results.

Original issue reported on code.google.com by gugakf...@gmail.com on 1 Sep 2007 at 2:05

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
im facing the "clear:after" problem too..

- made a container
- made few columns in it
- the container is not "cleared"
- i figure it out by adding traditional <br style="clear:left" /> before closing
container, seems like clearing solve the problem, so .container:after need to be
added back

gugakfugl,
can i have the declaration for .container:after class? this is my first time 
using
this framework, just downloaded it few minutes ago. thanks!

Original comment by pair...@gmail.com on 4 Sep 2007 at 4:44

GoogleCodeExporter commented 8 years ago
The missing code from 0.4 in its entirety (not sure how this will display):

/* Clearing floats without extra markup
   Based on How To Clear Floats Without Structural Markup by PiE
   [http://www.positioniseverything.net/easyclearing.html] */

.clear { display: inline-block; }   
.clear:after, .container:after {
    content: "."; 
    display: block; 
    height: 0; 
    clear: both; 
    visibility: hidden;
}
* html .clear { height: 1%; }
.clear { display: block; }

Original comment by gugakf...@gmail.com on 4 Sep 2007 at 4:58

GoogleCodeExporter commented 8 years ago
Fixed for the next release, see SVN if you need this right away. :)

Original comment by ola...@gmail.com on 4 Sep 2007 at 7:14