search

rbenv / rbenv-each

rbenv plugin to Run a command across all installed rubies.
Creative Commons Zero v1.0 Universal
91 stars 18 forks source link

Use bold instead of gray as gray is invisible on black background #12

Closed toy closed 8 years ago

mislav commented 9 years ago

Thanks for the contribution. Could we have some before/after screenshots? I was under the impression that GRAY was visible on a black background.

screen shot 2014-11-14 at 1 25 12 pm

toy commented 9 years ago

Escape code 1 means bold and/or bright, so depending on background and setting for bold/bright: Invisible (default «Pro» profile in Terminal.app): screen shot 2014-11-14 at 22 58 18 Somewhat visible (custom profile): screen shot 2014-11-14 at 22 58 06 Visible (another custom profile): screen shot 2014-11-14 at 22 58 34

After this pull-request: screen shot 2014-11-14 at 22 59 07 screen shot 2014-11-14 at 22 59 16 screen shot 2014-11-14 at 22 59 21

toy commented 8 years ago

Can this be merged?

mislav commented 8 years ago

Sorry for no update for so long, and thanks for the screenshots.

Looks like Terminal.app "Pro" scheme renders a semi-transparent background, and visibility of gray depends on what's behind the terminal window. For instance, here it's visible:

screen shot 2016-03-26 at 6 29 07 am

I would treat this as a problem with this terminal scheme's configuration rather than our usage of gray. I'm not a fan of your proposed change because it makes the divider bars way too prominently highlighted.

Even if someone can't see gray in their terminal, this plugin is still usable because the version strings are still visible. Therefore, I'd rather keep our colorscheme as-is and expect that people's terminals are able to see the full range of 8 basic ANSI colors.