Closed toy closed 8 years ago
Escape code 1 means bold and/or bright, so depending on background and setting for bold/bright: Invisible (default «Pro» profile in Terminal.app): Somewhat visible (custom profile): Visible (another custom profile):
After this pull-request:
Can this be merged?
Sorry for no update for so long, and thanks for the screenshots.
Looks like Terminal.app "Pro" scheme renders a semi-transparent background, and visibility of gray depends on what's behind the terminal window. For instance, here it's visible:
I would treat this as a problem with this terminal scheme's configuration rather than our usage of gray. I'm not a fan of your proposed change because it makes the divider bars way too prominently highlighted.
Even if someone can't see gray in their terminal, this plugin is still usable because the version strings are still visible. Therefore, I'd rather keep our colorscheme as-is and expect that people's terminals are able to see the full range of 8 basic ANSI colors.
Thanks for the contribution. Could we have some before/after screenshots? I was under the impression that GRAY was visible on a black background.