search

rbenv / rbenv-each

rbenv plugin to Run a command across all installed rubies.
Creative Commons Zero v1.0 Universal
91 stars 18 forks source link

Refactor how status works - keep "set -e" #18

Closed pvdb closed 9 years ago

pvdb commented 9 years ago

Hey @mislav - I personally find the way the status check is implemented in the script a tad confusing, so I'm offering two alternate implementations, one that keeps "set -e" (this one) and another one that removes it (see #17)

This PR keeps "set -e", but combines the two pipelines into a single one to avoid the need for the superfluous STATUS variable.

mislav commented 9 years ago

I like this!

I prefer to keep set -e because I use it standardly in every bash script.

pvdb commented 9 years ago

Awesome, thanks for merging!