search

rberman / Synesthesia

Ionic app that makes users' drawings into music
GNU General Public License v3.0
0 stars 0 forks source link

Canvas draws above where mouse is. #1

Closed rberman closed 8 years ago

rberman commented 8 years ago

The drawing on the canvas appears an inch or two over where the mouse is drawing. When we don't modify the variables startX, startY, endX, and endY (part of line object) to be between 0 and 100, then the line draws in the correct place, but it doesn't play music. Right now, either we can get it to play music, or we can get the canvas to draw in the right place. We want both.

mjaminbook commented 8 years ago

hmm, I get the line displacement either way, as long as I'm scrolled down to the play button. The line object doesn't look like it should actually affect the line being drawn. It looks like it is just storing the line, not being used to store it.

On Tue, Mar 1, 2016 at 10:17 PM, Ruthie Berman notifications@github.com wrote:

The drawing on the canvas appears an inch or two over where the mouse is drawing. When we don't modify the variables startX, startY, endX, and endY (part of line object) to be between 0 and 100, then the line draws in the correct place, but it doesn't play music. Right now, either we can get it to play music, or we can get the canvas to draw in the right place. We want both.

— Reply to this email directly or view it on GitHub https://github.com/rberman/Synesthesia/issues/1.

rberman commented 8 years ago

Actually, the displacement is a result of scrolling down the screen. This bug won't exist when we get rid of divs outside the canvas, so that the canvas just takes up the whole screen. Coolness.