search

rbicelli / pfsense-zabbix-template

Zabbix Template for pfSense
Apache License 2.0
240 stars 107 forks source link

Typo - Issue #104 #108

Closed GuillaumeHullin closed 1 year ago

GuillaumeHullin commented 2 years ago

(sorry, I thought I included it in yesterday PR)

GuillaumeHullin commented 2 years ago

Sorry, I went a bit quick on the copy/paste from my repo

GuillaumeHullin commented 2 years ago

Yes, I fully understand. I rebranded in my repo in order to fit with my other repos and my Zabbix setup.

I tried to make a middle forked-repo between yours and my main to avoid pushing my branding changes but I clearly mixed up myself.

Really sorry for the inconvenience.

I'm gonna review everything and ask for review once it's done.

GuillaumeHullin commented 2 years ago

I think I found why my PR changed more than what I planned on. When I created this PR almost a year ago, I should have created a separate branche in my fork... because all the changes with Futur-Tech branding that cames months after changed the content of this PR. Lesson learned.