rbicelli / pfsense-zabbix-template

Zabbix Template for pfSense
Apache License 2.0
238 stars 107 forks source link

Changes how the system version is tracked from direct to via a cronjob. #152

Closed AphidGit closed 10 months ago

AphidGit commented 10 months ago

Add instruction for how to enable this to .md file. Add both cronjobs to disable function. Add a timeout to stop a stuck function from causing problems.

I had some problems using this on our pfSense hosts: especially those with older hardware couldn't manage to get the version number. Restarting zabbix would get a few days where the version was tracked, but it would timeout afterwards.

I added it as a cronjob. Because I'm afraid that a long running task might lock up the zabbix system after enough of them hoard all the worker processes, I also added some timeouts to the script.

This is my first time doing a cross-repo pull request here, so please be kind if there's mistakes in how I set this up.

rbicelli commented 6 months ago

Hello @AphidGit , I accepted your PR almost blindly but noticed that cron job must be manually installed. When developing speedtest template part I made the cronjob install transparent. So it would be nice to install the cron job at first run of the value get.