rbjks / rbjks.github.io

Info website for an NGO 'Ranjeet Bakhshi Jan Kalyan Sabha' which aims to empower local communities in Himachal Pradesh
https://rbjks.github.io/
13 stars 37 forks source link

[BUG]: The introduction section is not designed properly and also the mobileview of that is not good can be changed. #115

Closed mohit-bhandari45 closed 4 months ago

mohit-bhandari45 commented 5 months ago

Is there an existing issue for this?

Current Behavior

Actually the introduction section of the website in home page is not looking good with inappropriate margins and padding. Also the mobile view is looking very bad and it can broken with the column flex direction.

Expected Behavior

The desktop view should be maintained with proper margin and padding. The mobile view should also be improved with proper direction of the sections and the image and text should be one below other.

Steps To Reproduce

1.Open the project 2.Preview the home page(index.html) 3.See the middle(introduction) section where there is image and text 4.See the middle(introduction) section in mobile view

Anything else?

image

What browsers are you seeing the problem on?

No response

CampbellBrim commented 5 months ago

I would like to work on this.

mohit-bhandari45 commented 5 months ago

I have done coding part of this please assign me

adityaraute commented 5 months ago

I have done coding part of this please assign me

Sorry @mohit-bhandari45 , Since you didn't indicate that you wanted to work on this issue in your description, I assigned it to the first person requesting so. Now that it is already assigned to someone, it won't be appropriate for us to assign it to you as well.

We encourage all contributors to only start working on an issue after you are assigned to it.

CampbellBrim commented 5 months ago

Captura de tela 2024-03-26 164119 I changed some of the margins and query rules. Does this look ok?

adityaraute commented 5 months ago
CampbellBrim commented 5 months ago

Sounds great! I wasn't sure if I should mention text color.

CampbellBrim commented 5 months ago

Before: Captura de tela 2024-03-26 171751 After: Captura de tela 2024-03-26 171719 Iphone 12 pro dimensions

mohit-bhandari45 commented 5 months ago

can i share my updates(ss) in this?

CampbellBrim commented 5 months ago

I am going to make small changes and post a pull request very soon.

adityaraute commented 5 months ago

I am going to make small changes and post a pull request very soon.

@CampbellBrim Sure, waiting for your PR

can i share my updates(ss) in this?

Feel free to share your comments @mohit-bhandari45 But since the issue is assigned already, the assignee will be raising the PR

CampbellBrim commented 5 months ago

I linked the PR to this issue. Does it look correct?

agriyakhetarpal commented 5 months ago

I think the "Fixes" keyword should be directly before the issue number – I fixed it for you

CampbellBrim commented 5 months ago

Thank you!

mohit-bhandari45 commented 5 months ago

please assign me I can do it easily

adityaraute commented 5 months ago

please assign me I can do it easily

This issue has already been assigned to someone else. Please don't request assignment in such a case.