rbjks / rbjks.github.io

Info website for an NGO 'Ranjeet Bakhshi Jan Kalyan Sabha' which aims to empower local communities in Himachal Pradesh
https://rbjks.github.io/
13 stars 37 forks source link

Fixed the footer of the website #138

Open mohit-bhandari45 opened 4 months ago

mohit-bhandari45 commented 4 months ago

Fixes #119

Description:- Fixed the overall ui structure of the footer with proper backgrounds and much more

How Has This Been Tested? I have tested the code by running it multiple times

Screenshots (if appropriate): Before:- image

After:- image

What types of changes does your code introduce?

Checklist:

mohit-bhandari45 commented 4 months ago

image

Is it good now?

adityaraute commented 4 months ago

image

Is it good now?

This looks better. Can you also post a screenshot of the mobile view?

mohit-bhandari45 commented 4 months ago

image

adityaraute commented 4 months ago

This is how it looks right now

image

The text is center aligned and I prefer it this way. Maybe you could replicate this and only change icons background and move text size back to normal.

mohit-bhandari45 commented 4 months ago

image is it good now??

adityaraute commented 4 months ago

Yes this looks good @mohit-bhandari45

mohit-bhandari45 commented 4 months ago

Done changes you can check

mohit-bhandari45 commented 3 months ago

I have done the changes you can check

adityaraute commented 3 months ago

image is it good now??

  1. The text in mobile view doesn't break into a newline at the required point, as can be seen in your previous messages.

  2. The icon is very close to the border.

image

Let me know if you're able to solve issue 1 without affecting the desktop view. Issue 2 needs to be solved.

mohit-bhandari45 commented 3 months ago

I cannot do it

adityaraute commented 3 months ago

I cannot do it

Okay 1 cannot be solved. Can 2 be solved? As in, can the icon be moved away from the left border?