Closed SidharthSreekumar closed 3 months ago
Hi @adityaraute,
The contact.css has a different indentation when compared to other CSS files. Most CSS files use 2 space indentation where this one was using 4 space. Same holds true for style.css, where most of the code in that file is having 2 space indentation and from line 246, it changes to 4 space. The contact.html file was also having indentation inconsistencies which were corrected in the commit. Please let me know if you still want me to revert these changes.
I see your point about the CSS files @SidharthSreekumar that's a very good spot and I'm happy to merge those files now.
However, the changes in HTML file still deviates from the rest of the repo and I would like those changes to be reverted before merging the PR.
Hi @adityaraute, I was trying to revert the changes to the contact.html file. But the lint-staged
is preventing me from doing a commit as it is mostly whitespace changes. Is there a workaround for this?
Moreover, I would like to add that npm run fix
reapplies the changes that I have on my original PR.
Is there a workaround for this?
You can probably do something like git commit -m "<your commit message>" --no-verify
Hi @adityaraute,
I have reverted the indentation fixes for contact.html
Thanks for the contribution!
Motivation and Context
The contents of the contact section spilled over to the footer when the website was viewed on small devices. Issue: link
Fixes
Description
How Has This Been Tested?
Tested on different screen sizes using browser dev tools. Tested on Mozilla Firefox and Google Chrome.
Screenshots (if appropriate):
Types of Changes
Checklist: