chore: Update CSS to improve footer image and text styling

rbjks / rbjks.github.io

Info website for an NGO 'Ranjeet Bakhshi Jan Kalyan Sabha' which aims to empower local communities in Himachal Pradesh

https://rbjks.github.io/

13 stars 37 forks source link

chore: Update CSS to improve footer image and text styling #145

Closed caiodutra08 closed 3 months ago

caiodutra08 commented 3 months ago

Motivation and Context

Fixes #124

Description

Added new styling rules to the main logo in larger screens, and in the text that was breaking letters when in mobile. Now in mobile, the main logo is aligned in the middle with the text and the text now only breaks words not letters.

How Has This Been Tested?

I tested with multiple dimensions. And actually doesn't affect any other areas.

Screenshots (if appropriate):

Types of Changes

[x] Bug fix (non-breaking change that fixes an issue)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

adityaraute commented 3 months ago

Added new styling rules to the main logo in larger screens and in the text that was breaking letters when in mobile.

Not sure what you mean by this.

Now in mobile, the main logo is aligned in the middle with the text

The logo is in the middle for the footer in mobile view on main branch. Not sure I understand this change either.

and the text now only breaks words not letters.

This seems to be fixed, and is the only desirable change.

caiodutra08 commented 3 months ago

Okay, I see what is your concern, I have only removed the padding so that it could be fully aligned in the middle. It had a margin or a padding (cant remember right now), and it wasn't properly aligned in the middle.

caiodutra08 commented 3 months ago

Great to hear!

caiodutra08 commented 3 months ago

Sorry, missclicked.

adityaraute commented 3 months ago

Thank you for your contribution!