rblack42 / project_template

This is a template for student projects I assign at ACC
1 stars 0 forks source link

Un-Idiomatic use of Make #1

Open the-maldridge opened 7 years ago

the-maldridge commented 7 years ago

In several places in your makefile, you call make directly. From the man page, I believe the invocation of Make for building the docs and running spellcheck should be using the -C option.

Additionally, make should probably be called as $(MAKE) unless have certainty that the version of make which will be first matched in $PATH is the one you want (while this is usually true I have run into several cases where it was not and spent more hours than I will admit fixing it).

I realize this is for a class (I stumbled upon it through a long series of links) but I still think there are a few improvements which could be made. This could probably also do with a minor cleanup in terms of removing the built artifacts, actually using the makefile in src/, and maybe making the calls to sphinx a little more robust.