search

rblopes / generator-phaser-plus

[🛑 DISCONTINUED] It has been a long journey but development of `generator-phaser-plus` is now over. I recommend you have a look and fork `yandeu/phaser-project-template` instead.
https://github.com/yandeu/phaser-project-template
MIT License
144 stars 14 forks source link

Generator hangs on README exists #24

Closed joehannes-zz closed 7 years ago

joehannes-zz commented 7 years ago

If a README exists I'm prompted what to do but the generator hangs instead of accepting input

rblopes commented 7 years ago

Can you confirm that only happens when there is a README.md file in the working folder? Does that happen when any other file that may get overwritten by the generator?

Also I need to know your OS, and which versions of Node.js and npm (or Yarn) you're using.

joehannes-zz commented 7 years ago

I can confirm it started working when I had the idea the existing README is the ... and removed it. I actually tried it again now and plaid with it, it also hangs on other files if they exist (tested: package.json)

how to reproduce ... simply run the generator twice in the same dir, you may ctrl+c the npm install

OS: Ubuntu 17.04 Node: 8.1.0 npm: 5.0.3

Cheers

rblopes commented 7 years ago

I'll request you to upgrade to Node.js v8.1.2 then. Your issue seems related to a regression in the readline module found recently (sources: 1, 2).

Edit: I tested both Node.js 8.1.0 and 8.1.2 and confirmed the problem only happens in 8.1.0.

joehannes-zz commented 7 years ago

I can confirm that as well. I updated to 8.1.2 and it started working :) Thx