search

rbn42 / pixelload

A Simple Fork of Indicator Multiload for KDE Plasma
GNU General Public License v3.0
7 stars 2 forks source link

don't use per-cpu stats #4

Closed pokab closed 4 years ago

pokab commented 4 years ago

On a 4-core machine with hardware 8 threads the per-cpu setting made things totally unreadable.

rbn42 commented 4 years ago

Hi pokab,

I created this widget because I want to use it myself. It was not hard because I copied another similar widget(panon) as a template. And for this widget alone, maybe it was a bad idea to use the hardware usage API of python, instead of KDE Plasma itself. I choose python because it was easier (with the template). But I am not willing to maintain and improve it.

I see you submitted 3 pull requests in a row, so I guess you are willing to make this widget better. If so, do you want me transfer this repository to you?

But I will reject this pull request if you don't want to take this repository. Because maybe someone else need per-cpu stats. Therefore we should make it an option, and let the user to choose. But as I said, I am not willing to improve it, so I will not make this option.

pokab commented 4 years ago

Hi!

I am in the process of implementing even more features. Same as you, primarily for myself. But you may be right, maybe someone still expects your functionality unmodified. My other patches will be more aggressive, and could break things. I'll be okay to stay a fork of your widget, rename it and push it to the KDE store separately.

rbn42 commented 4 years ago

I'll be okay to stay a fork of your widget, rename it and push it to the KDE store separately.

So I take it as YES. I should also transfer the product page of KDE store to you, but I don't know how.

pokab commented 4 years ago

You don't have to transfer the product page as long as I can register a new one. As I said, I won't touch the old widget.

rbn42 commented 4 years ago

OK, so be it. If you will push your widget to KDE store separately, please tell me what I can do for it.