search

rboldini / CoreBook_X_OC

OpenCore configuration to Install/Boot macOS 11.X+ on Chuwi CoreBook X
GNU General Public License v3.0
15 stars 8 forks source link

Support S/N JCorB 8th gen #11

Closed terminet85 closed 2 years ago

terminet85 commented 2 years ago

Hello! There is a fork for 8th gen https://github.com/weachy/CoreBookX-14-Hackintosh But I got a new CoreBooX gen8 revision (aka green motherboard version). I'll tried to use that OpenCore EFI, but I hang with this error:

No argument are initialized for method [FCPU]

ACPI Error: Method parse/execution failed [\LIDP.FCPU] (Node ffffff937a22a5a8 RE_NOT_FOUND (28160938/psparse-632)
ACPI Error: [\_SB_.PC18.LPC.H_EC.ADP1._PSR] Namespace lookup failure, RE_NOT_FOUND (28160938/psargs-463)
[FCPU] @00093 #882D:

Initialized Local Variables for method [FCPU]:
     Local0: ffffff9379f86500 <Obj>         Integer: 0000000000000001

Any advice for what should do I look in order to fix first this error? I'll share any fix that I could make, making a new branch of this git :)

Thank you so much

terminet85 commented 2 years ago

Disabling SSDT-LID-AC-Fix.aml I've installed MacOS. Wireless is working. Suspend mode too. Bad touchpad No audio No battery

I'm keep to investigate furthermore. SSDT-LID-AC-Fix.aml what is?

rboldini commented 2 years ago

Here a working repo https://github.com/sqlsec/CHUWI-COREBOOK-X-I5-8259U

Ssdt-lid-ac is not necessary for your model, is a fix for sleep by lid close and power adapter detection also ssdt bat is unnecessary and ssdt gpio with i2c trackpad implementation is different from mine in sqlsec's repo.

Your model also seems to be shipped in two variant:

The second one is not compatible with macOS neither exist a kext in developing.

What's differs in the EFI folder is just the config.plist I've one somewhere made for a friend with 8th gen model.

If you succeed in making one please consider to make a pull request with the new config named as config-8th-Gen.plist

terminet85 commented 2 years ago

Thank you for your reply and help!

I've used that repo (someone who forked you) https://github.com/weachy/CoreBookX-14-Hackintosh and I've disabled SSDT-LID-AC-Fix.aml and I was able to boot installer and got a working MacOS.

Looking weachy fork there is a lot of changing beyond config.plist, however I got some no working features:

-Trackpad left click or soft click doesn't work -No battery -No Audio -No multifunction (e.g. brightness)

Wireless is working :) Any advice for how fix these issues?

I've installed Monterey. Maybe it's only working with Big Sur?

terminet85 commented 2 years ago

@rboldini If you help me to fix battery, touchpad and audio (that is missing)... I'm ready to make a donation in order to thank you for spending ur time in this, let me know if you have time to :)

rboldini commented 2 years ago

It is not for donations that I carry out this project. If you think my work is interesting or useful, you are welcome to contribute with a donation.

Said that, my advice is to prepare everything from scratch:

  1. Download from Acidanthera's OpenCore repo latest Release. (0.7.7 right now)
  2. Download essentials Kext such as, Lilu, Whatevergreen, VirtualSMC, NVMeFixup, AirportItlwm (alpha recommended), ECEnabler, etc..

In general you can follow Dortania's Guide

Your model also doesn't need an SSDT-BATT for my experience.

Be sure to follow Dortania's Guide under Coffee Lake and Whiskey Lake when needed.

Just for the touchpad be sure to follow this kext order in config.plist:

Just for those kexts.

  1. PS2 Input
  2. PS2 Controller
  3. PS2 Keyboard
  4. VoodooI2C GPIO
  5. VoodooI2C Services
  6. VoodooI2C
  7. VoodooI2C HID

Others related kext (PS2 or VoodooI2C) need to bee disabled.

Anycubic commented 2 years ago

@terminet85 I have same Corebook version and tying to make it work with Big Sur, we can collaborate if you want, just let me know how to get in touch, there are no private messages in github, thanks

Anycubic commented 2 years ago

@rboldini could you please keep at least this issue opened? I'm willing to collaborate but if you close all of the related issues it's going to be hard! Thank you

Anycubic commented 2 years ago

Just for those kexts.

  1. PS2 Input
  2. PS2 Controller
  3. PS2 Keyboard
  4. VoodooI2C GPIO
  5. VoodooI2C Services
  6. VoodooI2C
  7. VoodooI2C HID

Others related kext (PS2 or VoodooI2C) need to bee disabled.

@rboldini like this? 2022-01-27_10-57-19

rboldini commented 2 years ago

Like this:

Screen Shot 2022-01-27 at 11 01 54

⚠️:

Your model also seems to be shipped in two variant:

Intel's Wi-Fi chipset Realtek Wi-Fi chipset The second one is not compatible with macOS neither exist a kext in developing.

Anycubic commented 2 years ago

Your model also seems to be shipped in two variant:

Intel's Wi-Fi chipset Realtek Wi-Fi chipset The second one is not compatible with macOS neither exist a kext in developing.

Luckily I have Intel! Should be possibile to fix audio (seems ALC269 and not ALC867) and trackpad. I also will implement your battery advices and report back. Do you you think it will be usefull extracting again all of the DSDT table e creating proper .aml? Sorry if I say nonsense, I started playing with Hackintosh when OpenCore didn't exist at all, now I need to learn again, thanks.

terminet85 commented 2 years ago

Hey @Anycubic :) As told by @rboldini I've restarted from scratch (less or more). I spent last two day to fix battery (yeah works now), you're lucky.

Audio was only to find the right layout-id, and touchpad fixed itself, configuration appeared when fixed battery.

I need to write the patch, because for debugging I'll modded directly to DSDT. When ready I'll make a GitHub

rboldini commented 2 years ago

The 8th Gen model I have, doesn't need battery patch in DSDT, I just need SMCBatteryManager and ECEnabler kexts. I haven't tried more on it cause of Realtek WiFi chipset.

Also in every repo I looked as reference for 8th gen model, aren't DSDT patches nor SSDT hot-patch for battery.

Anycubic commented 2 years ago

@terminet85 that's pretty a good news! If you want you can make a fork and push there your mods so I can test them as well on my unit. Which is the audio right layouu-id? Thanks

terminet85 commented 2 years ago

@rboldini but not this case. I needed to fix either ADP1 Device, _BIF and _BST. @Anycubic give me time to make patch...

Anycubic commented 2 years ago

@terminet85 ok I'll wait. Just let me know should you need any help 😉

rboldini commented 2 years ago

Please upload your vanilla DSDT. ( *.dsl format )

And please don't use this issue as chat, it will be open for update or questions.

Anycubic commented 2 years ago

I'm trying to install by myself (mostly to understand how OpenCore works, this is my first install). I got stuck here:

[EB|LOG:EXITBS:START] before you ask I'm sure I turned off CFG Lock in BIOS, what could it be possible be?

Thanks

rboldini commented 2 years ago

Some quirk in OC maybe try to match with my config quirks like ProvideCustomSlide etc..

To be sure inside the OC Release there is Documentation/Doc folder, where you can find a pdf with every quirk explained.

image

Anycubic commented 2 years ago

YES it did it! I got past and now I'm in the install screen but... everything is chinese! In which menu can I change the language? Thanks!

Anycubic commented 2 years ago

Ma sei italiano de Roma! 🤣 Ok, I guess I figured it out, don't want to spoil this issue thread anymore. Grazie 1000!

rboldini commented 2 years ago

Esattamente, però non romano di nascita.

Se volete si può fare un canale discord per organizzarvi.

In some time there will be an open project manager for this repo with every issue I found, in order to get some help.

Inviato da iPhone

Il giorno 28 gen 2022, alle ore 00:44, Anycubic @.***> ha scritto:

 Ma sei italiano de Roma! 🤣 Ok, I guess I figured it out, don't want to spoil this issue thread anymore. Grazie 1000!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

terminet85 commented 2 years ago

Allora è qui la festa 😂 Un po’ più al nord San Marino Ok per discord ✌️

Anycubic commented 2 years ago

I soliti italiani caciaroni (close to Forlì here)! 🤣 anche a me va bene discord. Ultima informazione di servizio e poi taccio: @terminet85 I've installed it starting from scratch and it is working fine (well, at least booted). I need to fix battery and other details, so please let me know when you will publish your work 😉

rboldini commented 2 years ago

Please upload here your decompiled DSDT (.dal) to let me check what’s wrong with your battery.

Also seems weachy’s repo is updated with my latest changes, no credit are given, but they are using my ASL patches.

Don’t use this repo, it’s unsafe.

Inviato da iPhone

Il giorno 28 gen 2022, alle ore 12:35, Anycubic @.***> ha scritto:  I soliti italiani caciaroni! 🤣 anche a me va bene discord. Ultima informazione di servizio e poi taccio: @terminet85 I've installed it starting from scratch and it is working fine (well, I least booted). I need to fix battery and other details, so please let me know when you will publish your work 😉

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

Anycubic commented 2 years ago

Right now I'm using this AML, from weachy's repo, I don't know if I can disable anything which maybe i affecting battery. Also mac model is wrong and not recognised: 2022-01-28_13-51-55

I extracted the DSDT.bin before erasing Windows partition. But do you need me to extract if from my Hackintosh, right? If this is what you need how can I do that? Thanks

rboldini commented 2 years ago

Not exactly, you can dump it from windows with ssdttime, Clover, OC Debug version or with patchmatic.

Guide

Here you can find most detailed guide i know for dsdt patching.

Just follow to the disassembling method and get your disassembled dsdt (.dsl format)

Then we'll use it to code some hot-patch.

Anycubic commented 2 years ago

Ok, I'll see what I can do. Right know I have my DSDT.bin extracted with RWEverything in Windows. Could it be useful for you? Otherwise I will follow the guide to extract it from hackintosh side

rboldini commented 2 years ago

I’ve not experience with binary ASL, really don’t know how to edit or disassembly it.

Just do an usb stick formatted GPT, mount EFI put latest version of clover, boot it, press F4 or FN+F4, reboot on OC and the job is done.

Now in EFI/Clover/ACPI/origin you have your assembled DSDT/SSDT.

Follow the guide below to disassembly it.

Inviato da iPhone

Il giorno 28 gen 2022, alle ore 14:51, Anycubic @.***> ha scritto:

 Ok, I'll see what I can do. Right know I have my DSDT.bin extracted with RWEverything in Windows. Could it be useful for you? Otherwise I will follow the guide to extract it from hackintosh side

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

Anycubic commented 2 years ago

Ok, I'll do it this evening, now I'm at work 😉

terminet85 commented 2 years ago

SSDT-CHUWI-JCorB-BATT.zip

                <dict>
                    <key>Base</key>
                    <string></string>
                    <key>BaseSkip</key>
                    <integer>0</integer>
                    <key>Comment</key>
                    <string>_BIF to XBIF</string>
                    <key>Count</key>
                    <integer>0</integer>
                    <key>Enabled</key>
                    <true/>
                    <key>Find</key>
                    <data>X0JJRgA=</data>
                    <key>Limit</key>
                    <integer>0</integer>
                    <key>Mask</key>
                    <data></data>
                    <key>OemTableId</key>
                    <data></data>
                    <key>Replace</key>
                    <data>WEJJRgA=</data>
                    <key>ReplaceMask</key>
                    <data></data>
                    <key>Skip</key>
                    <integer>0</integer>
                    <key>TableLength</key>
                    <integer>0</integer>
                    <key>TableSignature</key>
                    <data></data>
                </dict>
                <dict>
                    <key>Base</key>
                    <string></string>
                    <key>BaseSkip</key>
                    <integer>0</integer>
                    <key>Comment</key>
                    <string>_BST to XBST</string>
                    <key>Count</key>
                    <integer>0</integer>
                    <key>Enabled</key>
                    <true/>
                    <key>Find</key>
                    <data>X0JTVA==</data>
                    <key>Limit</key>
                    <integer>0</integer>
                    <key>Mask</key>
                    <data></data>
                    <key>OemTableId</key>
                    <data></data>
                    <key>Replace</key>
                    <data>WEJTVA==</data>
                    <key>ReplaceMask</key>
                    <data></data>
                    <key>Skip</key>
                    <integer>0</integer>
                    <key>TableLength</key>
                    <integer>0</integer>
                    <key>TableSignature</key>
                    <data></data>
                </dict>
                   <dict>
                    <key>Base</key>
                    <string></string>
                    <key>BaseSkip</key>
                    <integer>0</integer>
                    <key>Comment</key>
                    <string>BAT0 to XBAT</string>
                    <key>Count</key>
                    <integer>0</integer>
                    <key>Enabled</key>
                    <true/>
                    <key>Find</key>
                    <data>QkFUMA==</data>
                    <key>Limit</key>
                    <integer>0</integer>
                    <key>Mask</key>
                    <data></data>
                    <key>OemTableId</key>
                    <data></data>
                    <key>Replace</key>
                    <data>WEJBVA==</data>
                    <key>ReplaceMask</key>
                    <data></data>
                    <key>Skip</key>
                    <integer>0</integer>
                    <key>TableLength</key>
                    <integer>0</integer>
                    <key>TableSignature</key>
                    <data></data>
                </dict>

Here we go. Let's try it. This fix costed me days and days of research and ASL writing...

Anycubic commented 2 years ago

Here we go. Let's try it. This fix costed me days and days of research and ASL writing...

You are fast! I hope Xiānshēng Wheaky will at least thank you this time! 😉

Thanks, I'm going to test it

terminet85 commented 2 years ago

I've forgot to add _BIF to XBIF and _BST to BST, I've fix'd

Anycubic commented 2 years ago

I've forgot to add _BIF to XBIF and _BST to BST, I've fix'd

I'm sorry, where do I need to add the patches? Here? And how? I wan't able to find good information on how to do it

2022-01-28_19-48-33

I guess I also need to delete that line _BIF to XBIF? In general maybe it could be useful should you create a fork with your OpenCore files so that we can work on the same configuration/kext/etc

Anycubic commented 2 years ago

Not exactly, you can dump it from windows with ssdttime, Clover, OC Debug version or with patchmatic.

Guide

Here you can find most detailed guide i know for dsdt patching.

Just follow to the disassembling method and get your disassembled dsdt (.dsl format)

Then we'll use it to code some hot-patch.

@rboldini here 😉

DSDT.dsl.zip

rboldini commented 2 years ago

Mi confermate che il DSDT di @Anycubic è uguale a quello di @terminet85 ?

Se si la patch che hai scritto potrebbe essere sbagliata

Anycubic commented 2 years ago

Non so su quello di @terminet85, il mio Corebook è un JCorB con WIFI Intel e chip audio id=2. Ho seguito pedissequamente le istruzioni che mi hai dato

terminet85 commented 2 years ago

SSDT-CHUWI-JCorB-BATT.aml.zip

@Anycubic Maybe first read this https://dortania.github.io/OpenCore-Install-Guide/prerequisites.html you need some knowledge to sort out... You need SMCBatteryManager.kext and its dependency.

@rboldini That's same, sure there is something wrong I'm a newbie, what's your hints?

There is a new version, I've implemented 16byte to 8byte conversion, so its doesn't need anymore to load ECEnabler.kext, and I've re-write _OSI check strategy

rboldini commented 2 years ago

First of all you doesn't need to avoid ECEnabler injection, it actually helps a lot.

I noticed you removed some operation from bif and bst method. Why? Where do you find out what's stored inside your EC's fields ?

Your new BAT method need to be BAT0 and not XBAT, to do not broke the xbat patch you apply by OC. That patch is useless u don't need to change the whole BAT device, just overload methods that need some modification.

terminet85 commented 2 years ago

ECEnabler is only a 16bytes to 8bytes convertor, IMHO is much better done this conversion directly on the patch.

I've followed the ACPI 6.4 specs: https://uefi.org/specs/ACPI/6.4/10_Power_Source_and_Power_Meter_Devices/Power_Source_and_Power_Meter_Devices.html

I cannot overload a method that is already defined. _STA BAT0's method isn't return 0x1F (battery present), and I cannot patch only this method with OC.

terminet85 commented 2 years ago

SSDT-CHUWI-JCorB-BATT.aml.zip

Added fake S/N in order to fix Service Recommended warning. Hardcoded _BIF 0x01 and 0x04 to be more ACPI 6.4 compliant.

rboldini commented 2 years ago

You should, look at mine just bst and bif are touched

Inviato da iPhone

Il giorno 30 gen 2022, alle ore 11:54, terminet85 @.***> ha scritto:

 ECEnabler is only a 16bytes to 8bytes convertor, IMHO is much better done this conversion directly on the patch.

I've followed the ACPI 6.4 specs: https://uefi.org/specs/ACPI/6.4/10_Power_Source_and_Power_Meter_Devices/Power_Source_and_Power_Meter_Devices.html

I cannot overload a method that is already defined. _STA BAT0's method isn't return 0x1F (battery present), and I cannot patch only this method with OC.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

Anycubic commented 2 years ago

SSDT-CHUWI-JCorB-BATT.aml.zip

Added fake S/N in order to fix Service Recommended warning. Hardcoded _BIF 0x01 and 0x04 to be more ACPI 6.4 compliant.

Thanks, I'll test it

rboldini commented 2 years ago

Be aware that I’ve te reports the S/N issue to Acidanthera’s Group, you can find it in acidanthera/bugtracker. It will be fixed in future versions of VirtualSMC/SMCBatteryManager and the S/N injection will be useless. Inviato da iPhone

Il giorno 30 gen 2022, alle ore 13:05, Anycubic @.***> ha scritto:

 SSDT-CHUWI-JCorB-BATT.aml.zip

Added fake S/N in order to fix Service Recommended warning. Hardcoded _BIF 0x01 and 0x04 to be more ACPI 6.4 compliant.

Thanks, I'll test it

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

Anycubic commented 2 years ago

Be aware that I’ve te reports the S/N issue to Acidanthera’s Group, you can find it in acidanthera/bugtracker. It will be fixed in future versions of VirtualSMC/SMCBatteryManager and the S/N injection will be useless. Inviato da iPhone

Ok. I still didn't understand if and where I need to patch _BIF to XBIF, _BST to BST and BAT to BAT0 with that code that @terminet85 has provided. I'm good in reading and following directions but I need a specific place where I can find specific information.

Thanks 😉

Anycubic commented 2 years ago

While looking for how to apply those battery patch on the Net, I installed 10.15.7 as well and it is working pretty fine! Webcam is working (though little bit too dark, don't know if it is just crappy camera fault) also internal micro-sd reader is working fine. The only thing still missing is guess what? The battery! 🤣

terminet85 commented 2 years ago

Does your Ambient Light Sensor work? On my version it doesn’t work either on Windows and MacOS. Anyway I can find ALSD Device on my DSDT…

Anycubic commented 2 years ago

These are the other issues I have:

As you said, light sensor is selectable but it seems not working. I didn't check it under Windows, I'll try to understand if it's not working by definition and will never work actually. Can you take a screenshot of your DSDT devices? Thanks

rboldini commented 2 years ago

Ambient la sensor is not just light sensor, it detect the brightness of the screen and where colors are lighter, and change color profile.

On windows it work, on macos I had some problems with the srgb color profile.

Light sensors instead detects how many light is the room to change brightness

Inviato da iPhone

Il giorno 31 gen 2022, alle ore 07:56, Anycubic @.***> ha scritto:

 These are the other issues I have:

closing the lid doesn't make the MacBook go to sleep (but sleep works fine) trackpad soft clicks don't work As you said, light sensor is selectable but it seems not working. I didn't check it under Windows, I'll try to understand if it's not working by definition and will never work actually. Can you take a screenshot of your DSDT devices? Thanks

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

rboldini commented 2 years ago

For lid fix, I helped someone there:

https://www.reddit.com/r/hackintosh/comments/ptzftq/looking_for_help_debugging_some_acpi_issues_with/?utm_source=share&utm_medium=ios_app&utm_name=iossmf

The issue was on ADP1 but this works also for LID0 in my case. Try following those instruction.

For battery fix try to take a look on what smcbattery/ACPIBattery say in debug mode.

Inviato da iPhone

Il giorno 31 gen 2022, alle ore 07:56, Anycubic @.***> ha scritto:

 These are the other issues I have:

closing the lid doesn't make the MacBook go to sleep (but sleep works fine) trackpad soft clicks don't work As you said, light sensor is selectable but it seems not working. I didn't check it under Windows, I'll try to understand if it's not working by definition and will never work actually. Can you take a screenshot of your DSDT devices? Thanks

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

terminet85 commented 2 years ago
  • closing the lid doesn't make the MacBook go to sleep (but sleep works fine)

SSDT-LID-AC-Fix.zip

                <dict>
                    <key>Arch</key>
                    <string>Any</string>
                    <key>BundlePath</key>
                    <string>ACPIPoller.kext</string>
                    <key>Comment</key>
                    <string>V0.8.1</string>
                    <key>Enabled</key>
                    <true/>
                    <key>ExecutablePath</key>
                    <string>Contents/MacOS/ACPIPoller</string>
                    <key>MaxKernel</key>
                    <string></string>
                    <key>MinKernel</key>
                    <string></string>
                    <key>PlistPath</key>
                    <string>Contents/Info.plist</string>
                </dict>
  • trackpad soft clicks don't work

You need to load my battery Patch and VirtualSMC's Kext how I've already told to you to do and trackpad settings will appears.