rbong / vim-flog

A blazingly fast, stunningly beautiful, exceptionally powerful git branch viewer for Vim/Neovim.
795 stars 22 forks source link

Add mappings for reset branch and cherry-pick #115

Closed AlterDepp closed 10 months ago

AlterDepp commented 10 months ago

Add three new mappings:

rbong commented 10 months ago

Thank you for your contribution.

However, I'm sorry, I usually avoid adding new bindings to Flog to avoid any potential conflicts with future Fugitive bindings. I try to keep bindings as close to Fugitive as possible - the pro is that it's familiar to new users coming from Fugitive, the con is that we have to be very selective or risk confusing users in the future.

To add new bindings, I would need either:

You might be able to get git reset bindings added to Fugitive first, in which case I would add them here.

Cherry-pick on the other hand has no reason to exist in Fugitive because it can't view other branches in its status window. I would love to find a safe binding to add it to Flog under, but I haven't found anything yet. Maybe it's time for me to create a secondary plugin with more (unsafe) bindings, but there's really only a couple that would be useful that I can think of right now.

The alternative is to add these bindings to the Custom Commands wiki article and keep them in your vimrc. The wiki is publicly editable.

AlterDepp commented 10 months ago

Aren’t the bindings local to the flog buffer? So they should not conflict to other bindings.

rbong commented 10 months ago

It's not about conflicts, it's about familiarity and parity with the parent plugin of this plugin.

I try to keep bindings as close to Fugitive as possible - the pro is that it's familiar to new users coming from Fugitive, the con is that we have to be very selective or risk confusing users in the future.