search

rbong / vim-flog

A blazingly fast, stunningly beautiful, exceptionally powerful git branch viewer for Vim/Neovim.
750 stars 22 forks source link

E117: Unknown function: setcursorcharpos #99

Closed durka closed 1 month ago

durka commented 1 year ago

I'm getting this error whenever I run :Flog or :Flogsplit. After hitting enter the graph seems to load normally though.

Error detected while processing function flog#cmd#Flog[19]..flog#floggraph#buf#Update[32]..flog#floggraph#commit#RestorePosition[9]..flog#win#Restore[9]..flog#win#RestoreVcol:
line    2:
E117: Unknown function: setcursorcharpos
$ nvim --version
NVIM v0.6.1
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by team+vim@tracker.debian.org

Features: +acl +iconv +tui
rbong commented 1 year ago

I pushed a fix, please let me know if it works. I would recommend upgrading Neovim if at all possible though, 0.6.1 is a bit too old to justify support.

durka commented 1 year ago

Oh OK. 0.6.1 is the one included in Ubuntu 22.04 LTS at the moment :/ I will look into another way to install a newer version

On Fri, Mar 3, 2023 at 2:48 AM rbong @.***> wrote:

I pushed a fix, please let me know if it works. I would recommend upgrading Neovim if at all possible though, 0.6.1 is a bit too old to justify support.

— Reply to this email directly, view it on GitHub https://github.com/rbong/vim-flog/issues/99#issuecomment-1453112691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALPH4G5FZF3UYS4OHUE23W2GO4LANCNFSM6AAAAAAVOF5YXA . You are receiving this because you authored the thread.Message ID: @.***>

durka commented 1 year ago

Seems to have fixed the immediate issue, but now the next undefined function is virtcol2col.

durka commented 1 year ago

As you mentioned, 0.6.1 is old. I installed Neovim 0.8.3 from homebrew and there are no issues.

rbong commented 1 year ago

Seems to have fixed the immediate issue, but now the next undefined function is virtcol2col.

Sorry about that, if anyone wants to give a shot fixing this issue for older versions of neovim please be my guest. However I think wide char based functions were a lot more limited in older versions, I think you will have to reimplement virtcol2col.

rbong commented 1 month ago

I had to reimplement all of the wide char functions in v3 to also deal with concealed characters at the same time, so this support issue should pretty much be dead.