rbonghi / jetson_stats

📊 Simple package for monitoring and control your NVIDIA Jetson [Orin, Xavier, Nano, TX] series
https://rnext.it/jetson_stats
GNU Affero General Public License v3.0
2.16k stars 264 forks source link

Missing "," in os.symlink call #439

Closed albertfaromatics closed 10 months ago

albertfaromatics commented 1 year ago

Describe the bug

I think there's a missing "," in the call here:

https://github.com/rbonghi/jetson_stats/blob/98a6d1b7547b3842d0b921efbf9d3398e35335bf/jtop/jetson_config.py#L131

Found it when running jetson_config to set to boot to CLI directly with no desktop

To Reproduce

Steps to reproduce the behavior:

  1. run sudo jetson_config
  2. Go to Desktop
  3. Select B1
  4. Error pops out:

Traceback (most recent call last): File "/usr/local/bin/jetson_config", line 8, in <module> sys.exit(main()) File "/usr/local/lib/python3.8/dist-packages/jtop/jetson_config.py", line 238, in main curses.wrapper(JTOPCONFIG, MAIN_PAGE) File "/usr/lib/python3.8/curses/__init__.py", line 105, in wrapper return func(stdscr, *args, **kwds) File "/usr/local/lib/python3.8/dist-packages/jtop/gui/jtopguiconfig.py", line 74, in __init__ self.loop() File "/usr/local/lib/python3.8/dist-packages/jtop/gui/jtopguiconfig.py", line 154, in loop while not self.events(): File "/usr/local/lib/python3.8/dist-packages/jtop/gui/jtopguiconfig.py", line 167, in events status_keyboard = self.keyboard(event) File "/usr/local/lib/python3.8/dist-packages/jtop/gui/jtopguiconfig.py", line 201, in keyboard output = cmd() File "/usr/local/lib/python3.8/dist-packages/jtop/jetson_config.py", line 131, in desktop_set_B1 os.symlink('/lib/systemd/system/getty@.service' '/etc/systemd/system/getty.target.wants/getty@tty1.service') TypeError: symlink() missing required argument 'dst' (pos 2)

Board

Software part of jetson-stats 4.2.2 - (c) 2023, Raffaello Bonghi Jetpack missing!

ghost commented 1 year ago

Ran into the same issue, and I confirmed with local mods that the os.symlink call is the culprit. I can fix, look for a PR shortly.

rbonghi commented 10 months ago

Fixed on new jetson-stats release 4.2.4 Please update

sudo pip3 install -U jetson-stats