search

rbonghi / roboteq_control

⚙️ Driver for Roboteq devices using ros_control
MIT License
41 stars 12 forks source link

Memory leak from serial_controller #5 #6

Closed elhayra closed 4 years ago

elhayra commented 4 years ago

https://github.com/rbonghi/roboteq_control/issues/5

rbonghi commented 4 years ago

Thank you! I will merge soon!! :fireworks:

rbonghi commented 4 years ago

I have some questions for you :-)

In your pull request and I notice you comment or remove all parts about the dynamic reconfigure. This part is useful to setup the roboteq board, and when the node works doesn't leak the memory.

I also see you enable the motor controller without pass the parameters from urdf. I think in my package there is not a nice example to setup the URDF the board and run this package.

I'm making an example :+1:

elhayra commented 4 years ago

@rbonghi The truth is this was a long time ago, and I'm no longer work with Roboteq HW. But, I do remember that when I tried to use dynamic reconfigure it caused dynamic reconfigure GUI to crash, so I had to remove it in order to be able to use it along with other nodes.

About the second part - you are right. This is just customization I did for my purposes, and should not be included in your library.

Sorry for not filtering some of those things out, as I mentioned - this was a long time ago and I no longer have access to the HW for testing.

rbonghi commented 4 years ago

Hi @elhayra ,

I completely update my repository adding a example to show how it's work, and I hope now is more clear.

If there are more issues keep me posted.

I apologize for my delay