Noting here for posterity, it is suspected the use of sprintf with arbitrarily chosen string buffers may have been the partial cause of the segfaults when running the clang build. Part of this PR removed all use of sprintf and replaced it with std::string methods, including a new strmakef function which makes a std::string from a format list.
// method using sprintf
char message[256];
sprintf(message, "check %d %lf", 1, sqrt(2));
// the equivalent new method
std::string message = strmakef("check %d %lf", 1, sqrt(2));
The changes have not always been uniformly applied, and some work cleaning up how strings are handled is needed in the future.
Noting here for posterity, it is suspected the use of
sprintfwith arbitrarily chosen string buffers may have been the partial cause of the segfaults when running the clang build. Part of this PR removed all use of sprintf and replaced it withstd::stringmethods, including a newstrmakeffunction which makes astd::stringfrom a format list.The changes have not always been uniformly applied, and some work cleaning up how strings are handled is needed in the future.