Closed albertosantini closed 4 years ago
@albertosantini Thanks for creating this Issue, I will expose API to pass time zone. As you also referred Deno initially doesn't support TimeZone to toLocaleString
but I have noticed the created a bug ticket and they are working on it in the V8 level. So I am assuming the issue will be fixed soon. Thanks
I have created a separate branch where I implemented TimeZone. Since Deno does not has support yet for the toLocalString()
this feature not working as expected in Deno but works well with Nodejs. But Deno is working on it. Hopefully, it will be fixed soon in their upcoming update.
Hey. I hope you are fine.
Since Deno 1.8.0 ICU support has landed and now the test snippet above works correctly. See https://github.com/denoland/deno/issues/1968
Great!
Thanks for your module.
What about adding timezone? Inspired by https://github.com/kelektiv/node-cron.
Timezone is important because you can execute jobs on machines with a timezone different with respect to the job.
RFC for cron API:
cron(schedule, job, timezone)
:Then in
executeJobs
the validation is done for the following date:What do you think?
I noticed
toLocaleString
doesn't work. See https://github.com/denoland/deno/issues/1636 Compare the following snippet indeno
and innode
: