rbreaves / kinto

Mac-style shortcut keys for Linux & Windows.
http://kinto.sh
GNU General Public License v2.0
4.25k stars 213 forks source link

Add wget and python-pip to dependency list #723

Open Scosh opened 2 years ago

Scosh commented 2 years ago

Is your feature request related to a problem? Please describe. install on a clean arch linux and other minimalist distros does not work properly because wget and python and/or pip might not be installed.

Describe the solution you'd like add wget and python / python3-pip to the dependency (»What does Kinto require?«) list in the README.md

i know @ehaynes99 already complained about the python packaging method breaking the centrally managed philosophy of arch, but i am not expecting you to offer free support for a notoriously finicky, snowflake-y distro — plus, i don’t really care that this »breaks the arch philosphy« as the arch philosophy also has a lot of problems in my opinion …

i just think this could perhaps be easily fixed to be a bit more inclusive for now while you’re still using xkeysnail instead of keyszer by adding a small expansion to the README that reminds users on minmal linuxes to also check that they have whatever packages get them wget and the python3 version of pip. (still python3-pip on debian-based stuff, right? and python-pip for arch, manjaro)

if you’d like, i could quickly write up a pull request modifying the README accordingly :)

joshgoebel commented 2 years ago

about the python packaging method breaking the centrally managed philosophy of arch

How so? Is there a reason pip install --user can't be used? There is no need to install anything globally... I'm using/developing the new version of keyszer (fork of xkeysnail) and it runs just fine installed as user - with the normal Arch packages (python, pip, etc) supporting it.

There is no need for it to be installed globally.

joshgoebel commented 2 years ago

support for a notoriously finicky, snowflake-y distro

I'll forgive this gross miss-characterization. ;-)

exitflynn commented 1 year ago

Is this issue still active? I'd love to work on it!