search

rbreaves / kinto

Mac-style shortcut keys for Linux & Windows.
http://kinto.sh
GNU General Public License v2.0
4.24k stars 212 forks source link

[Win] New Fixes for Finder Mods (2024-06) #867

Open RedBearAK opened 3 weeks ago

RedBearAK commented 3 weeks ago

@rbreaves

Finder Mods for Windows Explorer had a number of issues that needed to be fixed, primarily coming from how the comparison was being made between the ClassNN attribute and a list of different possible strings to match on, for certain keys and shortcuts.

All issues with Enter, Backspace, Cmd+Backspace (Delete) and the Delete key seem to have been resolved in my testing on Windows 11. Renaming with Enter works on the desktop, and Cmd+Backspace is properly blocked to prevent deleting files on the desktop. Tab navigation shortcuts still working.

RedBearAK commented 3 weeks ago

@rbreaves

And of course after jumping into a different account on the same Windows 11 machine, I ran into a few more issues, and inconsistent ClassNN naming of different sections of the Explorer window. But I put in some additional logic to keep an error dialog from appearing in an old Control Panel window (Fonts), which is still part of Explorer.

It looks like I can't completely block the accidental usage of the Delete key in the desired places, but at least the fix for accidentally deleting a bunch of files on the desktop with Cmd+Backspace should still be working.

This PR should fix the same problem mentioned in issue #787, that was also something targeted by PR #795. I think I'll close that older PR, and also PR #769. They are obsoleted by this PR.

Edit: And also PR #768 is included in this PR, so closed that too.

RedBearAK commented 3 weeks ago

@rbreaves

Added another minor tweak that tries to get Cmd+Down to work on the desktop, for opening files and folders in place of the Enter key.

I've noticed a lot of strange inconsistency in both Explorer windows and the desktop, where sometimes things just don't work as intended right away, but the later they do, as if the ClassNN is different at first and doesn't match. Or perhaps there is some other cause related to restarting the AutoHotkey script to test the changes.

But once it starts working, it seems to keep working after that.

I'm not aware of anything else I can improve upon with this PR at this time, and I'm done updating this Win11 machine, so I probably won't mess with this again.