rbreu / beeref

BeeRef Reference Image Viewer
GNU General Public License v3.0
484 stars 39 forks source link

Fix crash when dragging an image and toggling on crop mode #114

Closed DarkDefender closed 1 month ago

DarkDefender commented 1 month ago

crop_mode_event_start would be set to None and thus crash the program. Add a check for this.

Note that going into crop mode can crash in different ways without #113. So this only fixes the crash I was able to reproduce with #113 applied.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.94%. Comparing base (6e3bc35) to head (e02ccc6). Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #114 +/- ## ======================================= Coverage 97.94% 97.94% ======================================= Files 33 33 Lines 4375 4375 ======================================= Hits 4285 4285 Misses 90 90 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rbreu commented 1 month ago

Thank a lot!