search

rbreu / beeref

BeeRef Reference Image Viewer
GNU General Public License v3.0
512 stars 38 forks source link

make type conversions to fix issue #54 #59

Closed KannebTo closed 10 months ago

badrihippo commented 2 years ago

Not sure what the merge process here is, but I can confirm that BeeRef started working for me on Manjaro after I manually applied changes to those same lines!

daishishi commented 1 year ago

Damn, more than eight months and no merge for three lines, three. I gave up on BeeRef after the 0.2 release crashed when trying to save (and had the issue #53 , and the developer 0.3 version didn't even started. After giving another try to fix myself I found the conversion problem on the file init.py (missed the view.py), and though of making my first ever FOSS contribution and pull/merge request. Checked the open Pull request and found this fix, but eight months of abandonment?! TLDR: I'm unsure of this project 'health'.

badrihippo commented 1 year ago

@daishishi there's a thread about this in #62. From what I can see, the maintainer hasn't been active for a while, so we should see if there's a possibility of handing over the project to someone else. If you hang in there, I'll check back in January when I'm less busy, and if nobody else steps in I'm thinking I'll fork the project myself, so that at least the pull requests can all be merged in!

rbreu commented 10 months ago

Sorry for the late reply, but thank you for the PR. The issue occurred when using a newer version of Qt than I was implementing against. I have since upgraded Qt, fixed this and a couple other issues, and also specified the exact version number of Qt in setup.py.