rbreu / beeref

BeeRef Reference Image Viewer
GNU General Public License v3.0
484 stars 39 forks source link

Jagged edges when rotating image. No antialiasing? #61

Closed Redstonerayy closed 2 years ago

Redstonerayy commented 2 years ago

Describe the bug When rotating an image, the edges are jagged which could be because no antialiasing is used. I think this can be enabled by setting a window hint like here

To Reproduce

  1. Open a bee file and rotate an image

Expected behavior It should rotate and look good.

fislysandi commented 2 years ago

ye i think this project is abandoned but it can be revived by someone

maybe we need some attention to this project since pureref hasnt been updated in a while.

fislysandi commented 2 years ago

unless a new maintainer comes to this project dont excpect for this to be fixed.

Redstonerayy commented 2 years ago

ok, thanks for the info

ghost commented 1 year ago

@mini-ninja-64 May you take a look on implementing antialiasing for BeeRef app? (in your fork)

In PureRef app it was implemented as Bilinear Sampling, applied to each image frame by default (and there is option to turn it off via context menu "Images > Selection > Toggle Bilinear Sampling" or with Alt+T shortcut).

mini-ninja-64 commented 1 year ago

@Symbian9 Seems fairly simple to add and great QoL improvement, just hard coding the flag acheives a much prettier result as shown in the attached image:

before_after

I can raise an issue on my fork and implement when I have some time

ghost commented 1 year ago

just hard coding the flag acheives a much prettier result as shown in the attached image:

@mini-ninja-64 It looking good!

But I mean not only "frame edge antialiasing", but also "bilinear sampling applying on all images" (is image is a texture inside frame?) after each change on canvas (zooming, moving, image frame resizing, etc.)

Try to use some blueprint as reference images.

Screenshot_2023-03-01_16-44-28

ghost commented 1 year ago

Seems fairly simple to add and great QoL improvement... I can raise an issue on my fork and implement when I have some time

And I just found that there is already open pull request that adds both: frame edge antialising and image filters during scaling/moving