search

rbrito / mediterranean-gtk-themes

Maintenance fork of the Mediterranean theme for GTK2/3.
GNU General Public License v3.0
53 stars 12 forks source link

"Transplant" necessary changes from MediterraneanNight to other themes. #26

Open rbrito opened 9 years ago

rbrito commented 9 years ago

To make the themes be even more similar (and all working as well as they should), we should "transplant" the changes that I made in the MediterraneanNight theme to the other themes. These can be seen (partially) with the command:

git diff --ignore-all-space 60c2b714.. MediterraneanNight
robertpainsi commented 9 years ago

Missing changes at the moment are only in gtk-2.0

git diff --ignore-all-space 60c2b714.. MediterraneanNight/gtk-2.0/
rbrito commented 9 years ago

On Feb 03 2015, Robert Painsi wrote:

Missing changes at the moment are only in gtk-2.0:

I think that I can deal with some of these, since I am still using MATE. Unfortunately, I don't really recall all the steps that I used to arrive at the result that I have right now.

There was some experimentation and trial and error, which, of course, may not be the easiest to reproduce.

For example:

style "terminal-notebook" {

  • bg[NORMAL] = shade( 0.85, @sidebar_background)
  • bg[ACTIVE] = shade( 0.70, @sidebar_background)
  • bg[NORMAL] = shade(1.1, @bg_color)
  • bg[ACTIVE] = shade(0.875, @bg_color)

Here is one instance where I had to experiment a bit.

That being said, I think that the users would let us know if something is broken or not. :)

Regards,

Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA http://cynic.cc/blog/ : github.com/rbrito : profiles.google.com/rbrito DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br

robertpainsi commented 9 years ago

I have to retract all of my comments above. It should be redone by scratch after the sass transition.

During the transition some code has been changed and all undefined colors have been defined (correctly?). Therfore reinspect all wm_* colors in the colors.scss files of all themes.

https://github.com/robertpainsi/pkg-mediterranean-gtk-themes/blob/cad144ac32d3cec1cbc8d8138f44ffb7b1fc4994/MediterraneanNight/gtk-3.0/scss/gtk.scss#L43-L46 https://github.com/robertpainsi/pkg-mediterranean-gtk-themes/blob/cad144ac32d3cec1cbc8d8138f44ffb7b1fc4994/MediterraneanNight/gtk-3.0/scss/gtk-widgets.scss#L7-L11