rbrito / usbmount

Simple set of scripts to automount removable devices for a Linux system
275 stars 86 forks source link

dpkg-buildpackage fails #10

Closed stefangweichinger closed 5 years ago

stefangweichinger commented 6 years ago

README: "sudo dpkg-buildpackage -us -uc -b" it fails. You depend on "lockfile-progs", right? ;-)

mathieulj commented 6 years ago

I'm not sure if your asking for help with something specific but your issue is lacking information. As written in the readme works for debian stretch. If you wish to add more information (ex. debian version, what doesn't work,...) it may help understand the issue, otherwise my recommendation would be to close it as un-reproducible.

The following is tested on a blank system via docker:

$ sudo docker run -it debian:stretch /bin/bash
# apt update && apt install -y git debhelper
# cd /opt
# git clone https://github.com/rbrito/usbmount.git
# cd usbmount
# dpkg-buildpackage -us -uc -b
# file ../usbmount_0.0.24_all.deb
stefangweichinger commented 6 years ago

debian stretch on hardware, not docker:

~/usbmount# dpkg-buildpackage -us -uc -b dpkg-buildpackage: Information: Quellpaket usbmount dpkg-buildpackage: Information: Quellversion 0.0.24 dpkg-buildpackage: Information: Quelldistribution unstable dpkg-buildpackage: Information: Quelle geändert durch Mathieu Letendre-Jauniaux mathieulj@gmail.com dpkg-buildpackage: Information: Host-Architektur amd64 dpkg-source --before-build usbmount dpkg-checkbuilddeps: Fehler: Nicht erfüllte Bauabhängigkeiten: build-essential:native dpkg-buildpackage: Warnung: Bauabhängigkeiten/-konflikte nicht erfüllt; Abbruch dpkg-buildpackage: Warnung: (Verwenden Sie -d, um sich darüber hinwegzusetzen.)

mathieulj commented 6 years ago

You seem to be missing the build-essential package which is a general dependency for building most software.

stefangweichinger commented 6 years ago

yes! thanks. Why don't you include that and lockfile-progs as dependencies? at least in the README ...

mathieulj commented 6 years ago

lockfile-progs is not required to build the package. It is however declared in the control file so apt should handle the dependency and install it automatically when the package is installed.

With that said, it may help future developers if it were documented more clearly(allong with the requirement for build-essential). I do not have commit access but I may take the time to create a pull request later (I dont have time right now) but your welcome to try to beat me to it ;)

stefangweichinger commented 6 years ago

lockfile-progs is not installed automatically here, I have to install it manually to be able to install usbmount. thanks for your help so far.

mathieulj commented 6 years ago

I assume you installed with dpkg -i ... if your dependencies were not installed. If so, you can follow up with apt-get -f install to install missing dependencies. A simpler alternative for local installs is to use a tool like gdebi that will install the dependencies automatically even when installing from a local package.