rbroker / ecodan-ha-local

Local HomeAssistant support for Air to Water Heat Pump Data/Control for Mitsubishi Ecodan
GNU General Public License v3.0
46 stars 10 forks source link

Holiday mode #42

Open drnichols opened 4 months ago

rbroker commented 4 months ago

Hi @drnichols,

Thanks for the PR! As you're adding a new control, I think it may be worth bumping the version number in ehal_config.cpp so that if anyone runs into issues it's easier to keep track of what version of the code they're working with.

Also, regarding the deletion of platformio.ini, I don't use platformio myself, and that was contributed by someone else. If it's not good practice to include it, is it better to rename it to something like "platformio.ini.example" instead of removing it?

Thanks, Richard