search

rbtcollins / fs_at

Filesystem 'at' implementations for Unix and Windows
12 stars 14 forks source link

add Apache-2.0 license text #121

Open decathorpe opened 10 months ago

decathorpe commented 10 months ago

The Apache-2.0 license is one of the many licences that requires the original license text to be included in (re)distributed sources. This PR adds the license text so that it is included when publishing to crates.io with cargo publish. For example, this is usually a requirement for getting something packaged in Linux distributions (which is what I am doing for Fedora Linux, as a new dependency of remove_dir_all v0.8).

The contents of the file match the LICENSE-APACHE file from the rust-lang/rust repository on GitHub.

If this PR is acceptable, then it would be great if you could tag and publish a new version on crates.io.

rbtcollins commented 4 months ago

I know its a common practice but this is the first time I've seen the claim that the license requires a verbatim copy in order for it to take effect. Can you please provide a citation? In particular, I couldn't find a clause in the license to that effect or with that implication. The appendix of the text version at https://www.apache.org/licenses/LICENSE-2.0.txt explicitly instructs people to refer to the licence by URL and does not specify to copy the license into the repository.

decathorpe commented 4 months ago

It's not about the license taking effect, but about a clause in the license itself:

(...)

4. Redistribution. You may reproduce and distribute copies of the
   Work or Derivative Works thereof in any medium, with or without
   modifications, and in Source or Object form, provided that You
   meet the following conditions:

   (a) You must give any other recipients of the Work or
       Derivative Works a copy of this License; and (...)

I also find the "simplified" summary of licenses as shown on choosealicense.com (Permissions / Conditions / Limitations) helpful: https://choosealicense.com/licenses/apache-2.0/

decathorpe commented 1 month ago

Could you take another look please? Reading your comment, it looks like there's been a misunderstanding. Please let me know if there is still something I can do to clear that up.