search

rbuchberger / jekyll_picture_tag

Easy responsive images for Jekyll.
https://rbuchberger.github.io/jekyll_picture_tag/
BSD 3-Clause "New" or "Revised" License
619 stars 103 forks source link

Rename gem to jekyll_picture_tag #120

Closed rbuchberger closed 5 years ago

rbuchberger commented 5 years ago

There are 2 reasons for this change:

The second is by far the bigger issue. During the time this plugin was stale, its original authors mostly moved on with their lives. I've tried to contact the owner of jekyll-picture-tag on rubygems via every channel I can find, without success.

From version 1.0 until now, it has been necessary to install jpt directly from this git repo, requiring an annoyingly verbose gemfile specification. This change fixes that, by renaming the plugin from jekyll-picture-tag to jekyll_picture_tag.

The problem here is that if I just rename everything and push it, everyone who has followed the installation instructions for the past several months will see their site break. (Their gemfile will reference the old name at this github repo, which it won't find here!)

To handle this, we create a duplicate gemspec under the old name which will load its corresponding rb file under lib. This file will print a warning message and then require the new one.

robwierzbowski commented 5 years ago

The owner is me! This is just never on my priority list. I've also lost my rubygems creds, and moved emails, so it's not as simple as just taking 10 mins out of the day.

I think this is a great direction.

robwierzbowski commented 5 years ago

Would you also like me to transfer this repo into your GH? Lemme see if I can do that now...

robwierzbowski commented 5 years ago

Looks like you have to delete your clone first.

rbuchberger commented 5 years ago

Done! I think that would definitely make things simpler, if you don't mind.

robwierzbowski commented 5 years ago

Done!

Thank you, and enjoy.

Rob Wierzbowski http://robwierzbowski.com

On Thu, Jun 6, 2019 at 9:47 AM Robert Buchberger notifications@github.com wrote:

Done! I think that would definitely make things simpler, if you don't mind.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/robwierzbowski/jekyll-picture-tag/issues/120?email_source=notifications&email_token=AAHCAJ7JJENGXQDVEPGX4VDPZEIO7A5CNFSM4GZIEZA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXC4NPY#issuecomment-499500735, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHCAJ4R2BWSBQQ5YESZHB3PZEIO7ANCNFSM4GZIEZAQ .

rbuchberger commented 5 years ago

Thank you much! I'll take good care of it.

I opened a ticket on rubygems asking for access; if that works out maybe we can avoid the rename altogether. Worst they can say is no