Closed egelmex closed 10 years ago
Interesting. Any suggestions? I'd like to keep the dimension information in the file name.
I hacked the script so the file names were 300WIDTHx250HEIGHT but that's not very elegant.
On Mon, Sep 16, 2013 at 5:00 PM, Rob Wierzbowski notifications@github.comwrote:
Interesting. Any suggestions?
— Reply to this email directly or view it on GitHubhttps://github.com/robwierzbowski/jekyll-picture-tag/issues/16#issuecomment-24521395 .
Do you have the matching pattern AdBlock uses? Seems a little broad.
It's in easylist https://easylist-downloads.adblockplus.org/easylist.txt which I think is the default adblock list.
Just search for "-300x250-"
On Mon, Sep 16, 2013 at 5:02 PM, Rob Wierzbowski notifications@github.comwrote:
Do you have the matching pattern AdBlock uses? Seems a little broad.
— Reply to this email directly or view it on GitHubhttps://github.com/robwierzbowski/jekyll-picture-tag/issues/16#issuecomment-24521634 .
Could you try "-300*250-" or "-(300x250)-"? Those don't seem too bad.
300*250 seems ok looking at the list. Might not have time to test this anytime soon.
On Mon, Sep 16, 2013 at 9:07 PM, Rob Wierzbowski notifications@github.comwrote:
Could you try "-300*250-" or "-(300x250)-"? Those don't seem too bad.
— Reply to this email directly or view it on GitHubhttps://github.com/robwierzbowski/jekyll-picture-tag/issues/16#issuecomment-24540208 .
Replacing the x with * sounds fine to me. If you can rolla PR that would be great, otherwise I'll get to it when JPT gets to the top of my open source todo stack again.
Closed with the above merge.
Create a 300x250px image and ad-block will hide it because the file name included "-300x250-".