Feedback wanted! - Githubissues

rbuchberger commented 3 years ago

With the 2.0 release, it's time for a new feedback thread. I moved the old one to a discussion thread awhile ago, but apparently nobody uses github discussions because it's been pretty dead. I want to hear about any of the following:

How are you deploying your Jekyll site with JPT installed? If you had to jump through some hoops to get it working with a particular service, would you mind sharing? That way we can make it easier for the next person.
How are you using JPT? There are no analytics, so I really have no idea how people use this plugin, or which features are the most important. I've created a discussion thread for this purpose.
How are the docs? Is it easy to find what you're looking for?
How are the error messages? Did you run into any that are completely unhelpful?
What are your pain points? How many WTF moments have you had, and what caused them?
Has JPT made your life easier?

Thanks!

IanCassTwo commented 3 years ago

What happens if I try to use v2 using Ruby 2.5? Debian Stable (v10, Buster) comes with 2.5 and I'd rather not have to install a newer version from source.

rbuchberger commented 3 years ago

It'll break; we started using some new features from 2.6. 2.5 is pretty old, and actually officially went EOL yesterday.

You don't have to build from source yourself; handling different versions of programming languagese is such a common problem that there are several good tools out there to handle it. asdf is the one I use, and can recommend it. rbenv is a ruby-specific alternative.

IanCassTwo commented 3 years ago

Yes but then it effectively bypasses Debian package management system. As a rule, I try to avoid doing that. It only causes problems in future. I'll try to find a Debian friendly way of updating to 2.6.

ankushg commented 3 years ago

I would love to know if anyone's successfully used JPT in Cloudflare Pages!

rbuchberger commented 3 years ago

I just tried a test build, looks like it's similar to netlify. No avif or jp2, but it can handle jpg, png, and webp.


Libvips known savers: csv, mat, v, vips, ppm, pgm, pbm, pfm, hdr, png, jpg, jpeg, jpe, webp, tif, tiff 
Imagemagick known savers: bzlib, cairo, djvu, fftw, fontconfig, freetype, jbig, jng, jpeg, lcms, lqr, ltdl, lzma, openexr, pangocairo, png, rsvg, tiff, wmf, x, xml, zlib
--

holzee commented 3 years ago

I am having a problem using JPT with Jekyll-Polyglot. It re-generates all of the images for every build. JPT seems to be not aware of the generated hash. Any clue?

sbij commented 2 years ago

I am having an issue with deploying to Netlify. Do i need something more in my build command than simply jekyll build? I have tried to deploy the JPT deployment tester repo (with just webp and original), and i get this error during Netlify build:

11:30:22 PM:        Jekyll Feed: Generating feed for posts
11:30:22 PM: Generating new image file: pestka-400-b9ca915fb.webp
11:30:22 PM:   Liquid Exception: No such file or directory - vips in index.markdown
11:30:22 PM:                     ------------------------------------------------
11:30:22 PM:       Jekyll 4.2.0   Please append `--trace` to the `build` command 
11:30:22 PM:                      for any additional information or backtrace. 
11:30:22 PM:                     ------------------------------------------------

I guess it is because it doesn't find vips-tools?

I have tried the build command brew install vips && jekyll build but I get the error 11:52:06 PM: Error: vips: no bottle available!

My build works if i dont use JPT. Am I missing something? Thank you for your plugin!

rbuchberger commented 2 years ago

@sbij Are you running their 2.0.2 build or later? I believe that's when they added vips.

sbij commented 2 years ago

@rbuchberger yes 11:51:22 PM: Using jekyll_picture_tag 2.0.3 from https://github.com/rbuchberger/jekyll_picture_tag (at master@0b0794b)

rbuchberger commented 2 years ago

I mean the netilfy build - site settings -> deploy -> build image. They've changed it since I last looked though; I believe you want the Ubuntu 20.04 image? Unless they pulled libvips out of it.

sbij commented 2 years ago

I am using Ubuntu Focal 20.04 indeed, other option is Ubuntu Xenial 16.04. I don't mind using either i think.

Sorry i'm not sure where to find the 2.0.2 info (edit: i get this info in my build log: 11:46:30 PM: build-image tag: v4.3.2)

duffn commented 2 years ago

Are you still having issues @sbij? The jpt tester repo builds successfully for me on Netlify with Ubuntu 20.04 and [webp, original] using jekyll_picture_tag 2.0.3.

sbij commented 2 years ago

@duffn i retried on Netlify (i switched to Cloudflare pages at the time, because of this issue) and now i dont have anymore problems, it works well with my repo on github

andreadellacorte commented 1 month ago

Hi @rbuchberger, rather than generating the images locally, could you rely on the https://docs.netlify.com/image-cdn/overview/ ? that's what I've been doing, but I think there may be a workable way to do what you're doing with some SaaS model

rbuchberger commented 1 month ago

Hi @andreadellacorte, thanks for the idea! I'm sorry to say that I flat out don't have the time or energy to build a feature like that. I'll happily accept pull requests, however.

andreadellacorte commented 1 month ago

I think I built it tonight!! Tested it on my website and it works.

It's wonky because I'm not the best at liquid filters parameters (it's a bit of a nightmare, I've found), but I think you'd be able to integrate it easily in your more mature set up.

I can make a gist and show you where I'm at, then we can discuss integrating and prs if you think it worthwhile.

rbuchberger commented 1 month ago

Sounds great! I'd love to see it.

andreadellacorte commented 1 month ago

Sounds great! I'd love to see it.

Emailed.

rbuchberger / jekyll_picture_tag

Feedback wanted! #240