rbuchberger / jekyll_picture_tag

Easy responsive images for Jekyll.
https://rbuchberger.github.io/jekyll_picture_tag/
BSD 3-Clause "New" or "Revised" License
622 stars 106 forks source link

Output names causes incompatibility with windows #35

Closed Everlag closed 10 years ago

Everlag commented 10 years ago

The change found here c5c70a9 to get around adblock also disables storing of images on a windows system due to the * which replaced the x.

I use virtualbox to build as I have to work in windows; The shared folder option allows me to write my site in windows and build it using ubuntu 12.04 so I can deploy it to a remote server. I started using this plugin and found that cp was returning a 'protocol error' due to the asterisk in the filename.

robwierzbowski commented 10 years ago

Thanks for the report. I think the windows error is of higher importance than the Adblock error, but hopefully we can fix both. I'll look through the Adblock blacklist and see if there's a better string we can use that is windows compatible.

On Saturday, March 22, 2014, Everlag notifications@github.com wrote:

The change found here c5c70a9https://github.com/robwierzbowski/jekyll-picture-tag/commit/c5c70a9to get around adblock also disables storing of images on a windows system due to the * which replaced the x.

I use virtualbox to build as I have to work in windows; The shared folder option allows me to write my site in windows and build it using ubuntu 12.04 so I can deploy it to a remote server. I started using this plugin and found that cp was returning a 'protocol error' due to the asterisk in the filename.

Reply to this email directly or view it on GitHubhttps://github.com/robwierzbowski/jekyll-picture-tag/issues/35 .

Rob Wierzbowski @robwierzbowski http://twitter.com/#!/robwierzbowski http://github.com/robwierzbowski http://robwierzbowski.com

Everlag commented 10 years ago

The fix, as I changed it to, simply replaces the asterick with a "by"; tested with chrome's adblock plus I've had no issues.

robwierzbowski commented 10 years ago

That's what I was thinking too. If by works, can you please submit a pull request?

On Saturday, March 22, 2014, Everlag notifications@github.com wrote:

Closed #35https://github.com/robwierzbowski/jekyll-picture-tag/issues/35 .

Reply to this email directly or view it on GitHubhttps://github.com/robwierzbowski/jekyll-picture-tag/issues/35 .

Rob Wierzbowski @robwierzbowski http://twitter.com/#!/robwierzbowski http://github.com/robwierzbowski http://robwierzbowski.com

Everlag commented 10 years ago

Pull request submitted.