search

rbuchmeier / nordicNumbers

0 stars 0 forks source link

Commented duplicate return statement #72

Closed schillingjerrid closed 6 years ago

schillingjerrid commented 6 years ago

Two return statements, one didn't have semicolon and it was commented.

schillingjerrid commented 6 years ago

@mariomarine Not sure if this was causing any issues but noticed a duplicate return statement without a semicolon

rbuchmeier commented 6 years ago

I agree, that was probably accidentally left after doing some debugging. @StrangeNectar looks like you made the last commit here. But it looks like you may have copied the code from somewhere else. Just for practice, it is worth having your review since you made the last change to it. @schillingjerrid once ben responds (or in a couple days if he doesn't), feel free to merge it in. Also setting us as reviewers can be helpful.

schillingjerrid commented 6 years ago

@mariomarine No problem. I had just commented it out because the code below was commented as well. I agree it seems like it was part of the original code and then missed when a section was commented out. I'll update the PR.