search

rbumm / SlicerLungCTAnalyzer

This is a 3D Slicer extension for segmentation and spatial reconstruction of infiltrated, collapsed, and emphysematous areas in lung CT.
Apache License 2.0
71 stars 23 forks source link

4.13.xx preview: LungCTSegmenter label texts missing and mask smoothing slower than previously #26

Closed rbumm closed 3 years ago

rbumm commented 3 years ago

When testing the LungCTSegmenter in Slicer 4.13.0-2021-08-05, placing the lung mask labels do not result in "R-1","R-2""R-3" labels as compared to the previous versions. The fiducials just show up as dots. 

When pressing "Apply", the generation of lung masks take longer than previously (127 [4.13] vs 56 s [4.11])

The "smoothing" part of the code takes longer (see statusMessages)

lassoan commented 3 years ago

placing the lung mask labels do not result in "R-1","R-2""R-3" labels as compared to the previous versions

Point labels visibility is set from the defaults (that is saved in "Advanced" settings). We may change Slicer core to use different defaults for curves (where point labels are rarely useful) and points (where point labels are usually important), but for now you can turn on label visibility when the fiducial list is initialized to ensure that labels are always visible.

I would recommend to add a separate ticket for the slower speed. It would be useful to know exactly which step of the smoothing part takes more time.