rburghol / om_agman

0 stars 0 forks source link

Inventory function issues #333

Open nita24 opened 1 year ago

nita24 commented 1 year ago

Hi Robert, Bill has been using the system quite a bit in the last few weeks, and encountered several issues. One big one is the inventory function. This is the list so far:

  1. [x] You will see duplicated entry in the "update inventory".
  2. [x] Updating the amount sometimes does not work.
  3. [ ] Adding chemicals from the inventory page does not work well.

https://www.awesomescreenshot.com/video/15561276?key=d7afdb58fb535ba824a42305cab82e60

rburghol commented 1 year ago

Thabks -- I will make this the number 1 priority!

rburghol commented 1 year ago

Just reviewed the video, clearly, something strange is happening with those duplicates showing up and the new chems not! I suspect that maybe the new chems aren't shown since they don't have any applications yet? Either way, I will investigate this now and sort it out.

rburghol commented 1 year ago

OK -- I believe that I have sorted this out. It was somewhat complicated, and in the end, I found that the bug was introduced when we switched to the searchable chemical addition method. The pointers that was in place for existing materials in the toolbox got re-used for the new material, leading to a confused inventory tracking. I have figured out what was wrong in that form, and verified that new chemical additions do not cause that problem.

In order for the problem to be resolved site-wide, we need to do a mass update in code, or users have to do so themselves. Or it will happen automatically the next time that the users add or remove a chemical from their toolbox. I think an announcement that there are bug fixes in the inventory system requires uses to go in and re-enter their inventory or at least verify that their inventory is correct -- if they are using inventory. Will follow up with an email.

rburghol commented 1 year ago

I'm going to leave this open, because I saw the trouble you had with adding chems, but I couldn't replicate it. I want to circle back on this and see if we can't get a set of steps to make it happen so that I can diagnose.