search

rburns / ansi-to-html

Convert ansi escaped text streams to html.
MIT License
357 stars 48 forks source link

Main coverage #74

Open brettz9 opened 4 years ago

brettz9 commented 4 years ago

With this PR, there is now 100% test coverage.

You should take an especially good look at the last 4 commits (before the last commit which is just an npm update), however, as I'm not sure if that apparently unreachable code I've removed had some other valid intention behind it.

brettz9 commented 4 years ago

Thanks for the review/merges! I've rebased this now as well as rebased #70.

rburns commented 4 years ago

thanks for all the pull requests. I'm unsure of the deleted code in this one. I haven't had a chance to look closely at it. But, will try to do that soon.

brettz9 commented 4 years ago

Just a friendly reminder if you're not too busy...

brettz9 commented 4 years ago

If you are ok with occasional reminders, here's a bump...

rburns commented 4 years ago

thanks for the reminder. I hope to get back to taking a look at this soon.