search

rbw / aiosnow

Asynchronous ServiceNow Library
MIT License
74 stars 12 forks source link

Fix error handling in Response.get_content() with test cases #43

Closed sulbig closed 4 years ago

sulbig commented 4 years ago

Resolves issue #42.

codecov-io commented 4 years ago

Codecov Report

Merging #43 into master will increase coverage by 56.86%. The diff coverage is 96.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #43       +/-   ##
===========================================
+ Coverage    0.28%   57.14%   +56.86%     
===========================================
  Files          34       35        +1     
  Lines         713      742       +29     
===========================================
+ Hits            2      424      +422     
+ Misses        711      318      -393
Impacted Files Coverage Δ
tests/request/core/test_base.py 96.55% <96.55%> (ø)
snow/request/core/base.py 53.62% <100.00%> (+53.62%) :arrow_up:
snow/request/helpers/stream.py 34.48% <0.00%> (+34.48%) :arrow_up:
snow/resource/__init__.py 35.16% <0.00%> (+35.16%) :arrow_up:
snow/resource/query/utils.py 36.36% <0.00%> (+36.36%) :arrow_up:
snow/request/core/get.py 41.66% <0.00%> (+41.66%) :arrow_up:
snow/request/helpers/update.py 42.10% <0.00%> (+42.10%) :arrow_up:
snow/resource/query/condition.py 42.85% <0.00%> (+42.85%) :arrow_up:
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f838a0...900c59d. Read the comment docs.

rbw commented 4 years ago

LGTM :+1: