rbwhitaker / CSharpPlayersGuideEarlyAccess

A place to track issues with the C# Player's Guide for patches and future editions
19 stars 0 forks source link

[WillowBear] The Old Robot has two `Run` methods that are a bit confusing #634

Closed rbwhitaker closed 1 year ago

rbwhitaker commented 2 years ago

I've seen several people struggle with the Old Robot challenge and how it is described, especially in regard to the fact that both the command and the robot itself both have a Run method that does similar but different things and easily leads to the wrong conclusion. This could be fixed by renaming one or both to something else. The robot's version to RunProgram or the command's version to RunCommand or Execute or something.

rbwhitaker commented 2 years ago

I still like this suggestion, but it is more involved than most of the changes happening in 5.0.1. It isn't just a simple tweak to the text in the book. It demands changing the solution code as well, which leaves you in a predicament because some people will have the version with two Run methods and others will have the version with one or the other tweaked.

I may punt on this until 6th Edition. But I'm at least pushing it out of 5.0.1 for now.

rbwhitaker commented 1 year ago

Fixed for 6th Edition. I'm leaving the command's method as Run and changing the robot's method to be RunProgram. It is the least intrusive change, and I think the names are reasonable.