rbxts-flamework / core

Flamework is an extensible game framework. It requires typescript and offers many useful features.
MIT License
101 stars 8 forks source link

BaseComponent.onAttributeChanged should return connection #52

Closed safazi closed 2 years ago

safazi commented 2 years ago

allow us to disconnect onAttributeChanged

Zyrakia commented 2 years ago

If memory leakage is your concern, the connection is automatically added to the component maid.

safazi commented 2 years ago

Alright cool, that's why I made the issue

Fireboltofdeath commented 2 years ago

https://github.com/rbxts-flamework/components/commit/5888ee8e80fe1d6dd4a5d089a22f886c89cc0516