search

rbxts-flamework / core

Flamework is an extensible game framework. It requires typescript and offers many useful features.
MIT License
101 stars 8 forks source link

`@flamework/networking` and `@flamework/components` should not use tsconfig.json `"baseUrl"` #54

Closed osyrisrblx closed 2 years ago

osyrisrblx commented 2 years ago

"baseUrl" does not work inside of installed packages, so imports within type definition files can break.

For example: node_modules/@flamework/networking/out/functions/types.d.ts

image

Fireboltofdeath commented 2 years ago

https://github.com/rbxts-flamework/components/commit/dc40193b93f42f96f917fd2c5e4a1ce67c5320b1 https://github.com/rbxts-flamework/networking/commit/2038d998268a956330072a0bcc9841b57500f65d